Skip to content

Commit

Permalink
Add 2020.1.4 release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
dominikh committed May 15, 2020
1 parent f4c568f commit f752e53
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 2 deletions.
28 changes: 28 additions & 0 deletions doc/2020.1.html
Expand Up @@ -10,6 +10,7 @@
<li><a href="#2020.1.1">Staticcheck 2020.1.1 release notes</a></li>
<li><a href="#2020.1.2">Staticcheck 2020.1.2 release notes</a></li>
<li><a href="#2020.1.3">Staticcheck 2020.1.3 release notes</a></li>
<li><a href="#2020.1.4">Staticcheck 2020.1.4 release notes</a></li>
</ul>

<h2 id="introduction">Introduction to Staticcheck 2020.1</h2>
Expand Down Expand Up @@ -192,3 +193,30 @@ <h2 id="2020.1.3">Staticcheck 2020.1.3 release notes</h2>
</li>
</ul>
</p>

<h2 id="2020.1.4">Staticcheck 2020.1.4 release notes</h2>

<p>
This release adds special handling for imports of the
deprecated <code>github.com/golang/protobuf/proto</code> package.
</p>

<p>
<a href="https://github.com/golang/protobuf">github.com/golang/protobuf</a>
has deprecated the <code>proto</code> package, but
their <code>protoc-gen-go</code> still imports the package and uses
one of its constants, <q>to enforce a weak dependency on a
sufficiently new version of the legacy package</q>.
</p>

<p>
Staticcheck would flag the import of this deprecated package in all
code generated by protoc-gen-go. Instead of forcing the project to
change their project structure, we choose to ignore such imports in
code generated by protoc-gen-go. The import still gets flagged in code
not generated by protoc-gen-go.
</p>

<p>
You can find more information about this in the <a href="https://github.com/golang/protobuf/issues/1077">upstream issue</a>.
</p>
4 changes: 2 additions & 2 deletions doc/staticcheck.html
Expand Up @@ -22,12 +22,12 @@ <h2 id="installation">Installation</h2>
<p>
If you use Go modules, you can simply run <code>go get honnef.co/go/tools/cmd/staticcheck</code> to obtain the latest released version.
If you're still using a GOPATH-based workflow, then the above command will instead fetch the master branch.
It is suggested that you explicitly check out the latest release branch instead, which is currently <code>2020.1.3</code>.
It is suggested that you explicitly check out the latest release branch instead, which is currently <code>2020.1.4</code>.
One way of doing so would be as follows:
</p>

<pre><code>cd $GOPATH/src/honnef.co/go/tools/cmd/staticcheck
git checkout 2020.1.3
git checkout 2020.1.4
go get
go install
</code></pre>
Expand Down

0 comments on commit f752e53

Please sign in to comment.