SA9001: fix false positive in presense of control flow statement #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in the PR: dominikh#488, let's check if there is either a `return` statement or a `break` control flow when looping over channels. This would reduce false positives. Add a test for the same as noted in the issue! Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
dominikh
pushed a commit
that referenced
this pull request
Aug 17, 2023
As noted in issue gh-488, let's check if there is either a 'return' or a 'break' statement when looping over channels. Add a test for the same as noted in the issue! Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Closes: gh-1298 [via git-merge-pr] Closes: gh-488 (cherry picked from commit bfa1dc5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the Issue: #488,
let's check if there is either a
returnstatement or abreakcontrolflow when looping over channels. This would reduce false positives.
Add a test for the same as noted in the issue!