fix some unit test #136
dominikus1993Annotations
11 warnings
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build:
src/XboxPromotionCheckerBot.App/Core/Types/XboxGame.cs#L18
Nullability of reference types in type of parameter 'other' of 'int PromotionPercentage.CompareTo(PromotionPercentage other)' doesn't match implicitly implemented member 'int IComparable<PromotionPercentage>.CompareTo(PromotionPercentage? other)' (possibly because of nullability attributes).
|
|
build:
src/XboxPromotionCheckerBot.App/Core/Filters/GameNameFilter.cs#L7
Non-nullable field '_normalizedTitle' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/Extensions/WebApplicationBuilderExtensions.cs#L21
Possible null reference argument for parameter 'connection' in 'IMongoClient MongoDbSetup.MongoClient(string connection)'.
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/Extensions/WebApplicationBuilderExtensions.cs#L37
Possible null reference argument for parameter 'filePath' in 'GameNameFilter FuzzyGameSearcherFactory.Produce(string filePath)'.
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/Factories/FuzzyGameSearcherFactory.cs#L15
Non-nullable property 'Title' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/MongoDb/MongoXboxGame.cs#L16
Non-nullable property 'Title' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/MongoDb/MongoXboxGame.cs#L16
Non-nullable property 'Link' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
|
|
build:
src/XboxPromotionCheckerBot.App/Core/Types/XboxGame.cs#L101
Member 'IsValidGame' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
build:
src/XboxPromotionCheckerBot.App/Core/Crypto/IdGenerator.cs#L21
GenerateId uses a broken cryptographic algorithm MD5 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5351)
|
|
build:
src/XboxPromotionCheckerBot.App/Infrastructure/Factories/FuzzyGameSearcherFactory.cs#L13
'FuzzyGameSearcherFactory.Game' is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it 'static' (Module in Visual Basic). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812)
|