use TheoryData

dominikus1993 · Jan 27, 2024 · 7c57e1d · 7c57e1d
1 parent 29be1c2
commit 7c57e1d
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/src/XboxPromotionCheckerBot.App/Core/Filters/GamePriceFilter.cs b/src/XboxPromotionCheckerBot.App/Core/Filters/GamePriceFilter.cs
@@ -17,7 +17,7 @@ public async IAsyncEnumerable<XboxGame> Filter(IAsyncEnumerable<XboxGame> games,
         ArgumentNullException.ThrowIfNull(games);
         await foreach (var game in games.WithCancellation(cancellationToken))
         {
-            if (game.PromotionPercentage >= _minimumPercentage)
+            if (game.PromotionPercentage() >= _minimumPercentage)
             {
                 yield return game;
             }

diff --git a/src/XboxPromotionCheckerBot.App/Core/Types/XboxGame.cs b/src/XboxPromotionCheckerBot.App/Core/Types/XboxGame.cs
@@ -85,7 +85,7 @@ public override int GetHashCode()
     public Uri Link { get; }
     public GamePrice GamePrice { get; }
 
-    public PromotionPercentage PromotionPercentage => GamePrice.CalculatePromotionPercentage();
+    public PromotionPercentage PromotionPercentage() => GamePrice.CalculatePromotionPercentage();
 
     public static XboxGame Create(Title title, Uri link, GamePrice gamePrice)
     {

diff --git a/src/XboxPromotionCheckerBot.App/Infrastructure/Notifiers/DiscordGameNotifier.cs b/src/XboxPromotionCheckerBot.App/Infrastructure/Notifiers/DiscordGameNotifier.cs
@@ -53,11 +53,11 @@ private static IEnumerable<Embed> MapEmbeds(IEnumerable<XboxGame> games)
         }
     }
 
-    private static Color GetColorByPromotionLevel(XboxGame game) => game.PromotionPercentage.Value switch
+    private static Color GetColorByPromotionLevel(XboxGame game) => game.PromotionPercentage() switch
     {
-        > 90 => Color.Gold,
-        > 70 => Color.Red,
-        > 50 => Color.Green,
+        { Value:> 90 } => Color.Gold,
+        { Value:> 70 } => Color.Red,
+        { Value:> 50 } => Color.Green,
         _ => Color.Default,
     };
 }
diff --git a/tests/XboxPromotionCheckerBot.App.Tests/Core/Types/XboxGameTests.cs b/tests/XboxPromotionCheckerBot.App.Tests/Core/Types/XboxGameTests.cs
@@ -5,22 +5,22 @@ namespace XboxPromotionCheckerBot.App.Tests.Core.Types;
 public class XboxGameTests
 {
     [Theory]
-    [MemberData(nameof(PromotionPercentageData))]
+    [ClassData(typeof(PromotionPercentageData))]
     public void TestPromotionPercentage(XboxGame game, PromotionPercentage promotion)
     {
-        var subject = game.PromotionPercentage;
+        var subject = game.PromotionPercentage();
 
         Assert.Equal(promotion, subject);
     }
-    
-    
-    
-    public static IEnumerable<object[]> PromotionPercentageData =>
-        new List<object[]>
-        {
-            new object[] { XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(10, 20)), new PromotionPercentage(50d) },
-            new object[] { XboxGame.Create(Guid.NewGuid(),"x", new Uri("http://test.pl"), new GamePrice(10)), PromotionPercentage.Zero },
-            new object[] { XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(10, 100)), new PromotionPercentage(90d) },
-            new object[] { XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(134.99m, 269.99m)), new PromotionPercentage(50d) },
-        };
+}
+
+public sealed class PromotionPercentageData : TheoryData<XboxGame, PromotionPercentage>
+{
+    public PromotionPercentageData()
+    {
+        Add(XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(10, 20)), new PromotionPercentage(50d));
+        Add(XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(10)), PromotionPercentage.Zero);
+        Add(XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(10, 100)), new PromotionPercentage(90d));
+        Add(XboxGame.Create(Guid.NewGuid(), "x", new Uri("http://test.pl"), new GamePrice(134.99m, 269.99m)), new PromotionPercentage(50d));
+    }
 }