Skip to content

Merge pull request #72 from dominikwilkowski/dep-update #159

Merge pull request #72 from dominikwilkowski/dep-update

Merge pull request #72 from dominikwilkowski/dep-update #159

GitHub Actions / clippy succeeded Aug 17, 2023 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.71.1 (eb26296b5 2023-08-03)
  • cargo 1.71.1 (7f1d04c00 2023-07-29)
  • clippy 0.1.71 (eb26296 2023-08-03)

Annotations

Check warning on line 306 in src/gradient.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`i8` -> `i8`)

warning: casting to the same type is unnecessary (`i8` -> `i8`)
   --> src/gradient.rs:306:22
    |
306 |     let mut gaps = vec![transition_steps as i8; colors.len() - 1];
    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `transition_steps`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 305 in src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `default` can be confused for the standard trait method `std::default::Default::default`

warning: method `default` can be confused for the standard trait method `std::default::Default::default`
   --> src/config.rs:285:2
    |
285 | /     pub fn default() -> Self {
286 | |         Options {
287 | |             text: String::from(""),
288 | |             font: Fonts::FontBlock,
...   |
304 | |         }
305 | |     }
    | |_____^
    |
    = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
    = note: `#[warn(clippy::should_implement_trait)]` on by default

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:67
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                                      ^^^^^^^ help: try: `{ b }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:58
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                             ^^^^^^^ help: try: `{ g }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:49
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                    ^^^^^^^ help: try: `{ r }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 306 in src/gradient.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`i8` -> `i8`)

warning: casting to the same type is unnecessary (`i8` -> `i8`)
   --> src/gradient.rs:306:22
    |
306 |     let mut gaps = vec![transition_steps as i8; colors.len() - 1];
    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `transition_steps`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 305 in src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `default` can be confused for the standard trait method `std::default::Default::default`

warning: method `default` can be confused for the standard trait method `std::default::Default::default`
   --> src/config.rs:285:2
    |
285 | /     pub fn default() -> Self {
286 | |         Options {
287 | |             text: String::from(""),
288 | |             font: Fonts::FontBlock,
...   |
304 | |         }
305 | |     }
    | |_____^
    |
    = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
    = note: `#[warn(clippy::should_implement_trait)]` on by default

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:67
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                                      ^^^^^^^ help: try: `{ b }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:58
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                             ^^^^^^^ help: try: `{ g }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 206 in src/color.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u8` -> `u8`)

warning: casting to the same type is unnecessary (`u8` -> `u8`)
   --> src/color.rs:206:49
    |
206 |     let result = format!("#{:0>2x}{:0>2x}{:0>2x}", r as u8, g as u8, b as u8);
    |                                                    ^^^^^^^ help: try: `{ r }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default