Use latest coding standard

.scrutinizer.yml

@@ -1,25 +1,23 @@
 filter:
     excluded_paths:
         - 'vendor/*'
-        - 'tests/*'
 before_commands:
     - 'composer install --prefer-source'
 build:
     tests:
         override:
-            - phpcs-run --standard=./vendor/chadicus/coding-standard/Chadicus/ruleset.xml
+            - phpcs-run --standard=./vendor/chadicus/coding-standard/Chadicus/ruleset.xml -n src tests
 tools:
     php_analyzer: true
     php_mess_detector: true
     sensiolabs_security_checker: true
     php_loc:
         excluded_dirs:
             - vendor
-            - tests
     php_pdepend: true
     php_sim: true
 build_failure_conditions:
-    - 'elements.rating(<= B).new.exists'
+    - 'elements.rating(< B).new.exists'
     - 'issues.label("coding-style").new.exists'
     - 'issues.severity(>= MAJOR).new.exists'
     - 'project.metric("scrutinizer.quality", < 6)'

composer.json

@@ -27,7 +27,7 @@
     "require-dev": {
         "phpunit/phpunit": "^5.5",
         "satooshi/php-coveralls": "^1.0",
-        "chadicus/coding-standard": "^1.1"
+        "chadicus/coding-standard": "^1.3"
     },
     "autoload": {
         "psr-4": { "DominionEnterprises\\Cronus\\": "src" }

phpcs.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0"?>
+<ruleset name="PHP_CodeSniffer">
+    <file>./src</file>
+    <file>./tests</file>
+    <arg value="p" />
+    <rule ref="./vendor/chadicus/coding-standard/Chadicus"/>
+</ruleset>

src/ProcessRegistry.php

@@ -63,7 +63,7 @@ public function add(
         int $maxGlobalProcesses = 1,
         int $maxHostProcesses = 1
     ) : bool {
-        $thisHostName = self::_getEncodedHostname();
+        $thisHostName = self::getEncodedHostname();
         $thisPid = getmypid();
 
         //loop in case the update fails its optimistic concurrency check
@@ -143,7 +143,7 @@ public function add(
      */
     public function remove(string $id)
     {
-        $thisHostName = self::_getEncodedHostname();
+        $thisHostName = self::getEncodedHostname();
         $thisPid = getmypid();
 
         $this->collection->updateOne(
@@ -166,7 +166,7 @@ public function reset(string $id, int $minsBeforeExpire)
         //ensure expireSecs is between 0 and self::MONGO_INT32_MAX
         $expireSecs = max(0, min($expireSecs, self::MONGO_INT32_MAX));
 
-        $thisHostName = self::_getEncodedHostname();
+        $thisHostName = self::getEncodedHostname();
         $thisPid = getmypid();
 
         $this->collection->updateOne(
@@ -185,7 +185,7 @@ public function reset(string $id, int $minsBeforeExpire)
      *
      * @return string the encoded hostname from gethostname().
      */
-    private static function _getEncodedHostname() : string
+    private static function getEncodedHostname() : string
     {
         return str_replace(['.', '$'], ['_DOT_', '_DOLLAR_'], gethostname());
     }

tests/ProcessRegistryTest.php

@@ -131,7 +131,7 @@ public function addOverMaxGlobalProcessesOnDifferentHost()
     public function addOverMaxGlobalProcessesOnSameHost()
     {
         $pipes = [];
-        $process = proc_open('sleep 10 &', self::_getDevNullProcOpenDescriptors(), $pipes);
+        $process = proc_open('sleep 10 &', self::getDevNullProcOpenDescriptors(), $pipes);
         $status = proc_get_status($process);
         if (!$status['running']) {
             $this->markTestSkipped('Unable to start sleep process.');
@@ -158,7 +158,7 @@ public function addOverMaxGlobalProcessesOnSameHost()
     public function addOverMaxHostProcesses()
     {
         $pipes = [];
-        $process = proc_open('sleep 10 &', self::_getDevNullProcOpenDescriptors(), $pipes);
+        $process = proc_open('sleep 10 &', self::getDevNullProcOpenDescriptors(), $pipes);
         $status = proc_get_status($process);
         if (!$status['running']) {
             $this->markTestSkipped('Unable to start sleep process.');
@@ -217,7 +217,7 @@ public function addCleaningNotRunningProcessWithoutExtra()
     public function addCleaningNotRunningProcessWithExtra()
     {
         $pipes = [];
-        $process = proc_open('sleep 3 &', self::_getDevNullProcOpenDescriptors(), $pipes);
+        $process = proc_open('sleep 3 &', self::getDevNullProcOpenDescriptors(), $pipes);
         $status = proc_get_status($process);
         if (!$status['running']) {
             $this->markTestSkipped('Unable to start sleep process.');
@@ -370,7 +370,7 @@ public function addCleaningRecycledProcessWithoutExtra()
     public function addCleaningRecycledProcessWithExtra()
     {
         $pipes = [];
-        $process = proc_open('sleep 3 &', self::_getDevNullProcOpenDescriptors(), $pipes);
+        $process = proc_open('sleep 3 &', self::getDevNullProcOpenDescriptors(), $pipes);
         $status = proc_get_status($process);
         if (!$status['running']) {
             $this->markTestSkipped('Unable to start sleep process.');
@@ -645,7 +645,7 @@ public function addTooMuchConcurrency()
      *
      * @return array
      */
-    private static function _getDevNullProcOpenDescriptors() : array
+    private static function getDevNullProcOpenDescriptors() : array
     {
         return [0 => ['file', '/dev/null', 'r'], 1 => ['file', '/dev/null', 'w'], 2 => ['file', '/dev/null', 'w']];
     }