Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM-42841 Removing beta messaging on datasource_client instantiation #85

Merged
merged 1 commit into from Jan 26, 2023

Conversation

ddl-aj-rossman
Copy link
Contributor

@ddl-aj-rossman ddl-aj-rossman commented Jan 26, 2023

Description

Removing beta messaging from sdk on instantiation of datasource_client. Will be removing environment variable from nucleus next:)

Shouldn't go in 5.5 release FYI

https://dominodatalab.atlassian.net/browse/DOM-42841

Related Issue

Do it!

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.16-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 84 12 86%
domino_data/configuration_gen.py 164 0 100%
domino_data/data_sources.py 260 14 95%
domino_data/logging.py 10 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
TOTAL 907 67 93%

~ 55 passed in 21.30s ~

@ddl-aj-rossman ddl-aj-rossman merged commit 414a50d into main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants