Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-31225] - update certificates to bypass verify #139

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

ddl-olsonJD
Copy link
Collaborator

@ddl-olsonJD ddl-olsonJD commented Aug 2, 2022

Link to JIRA

DOM-31225

What issue does this pull request solve?

because certification verification is defaulted to true, that prevent some users from using the python-wrapper.

What is the solution?

added environment variable to allow request to bypass verify.

Testing

set environment variable DOMINO_VERIFY_CERTIFICATE to true, and instantiate domino. It should give you a warning to add certificate verification

  • Unit test(s)

Pull Request Reminders

References (optional)

@ddl-olsonJD ddl-olsonJD changed the title [DOM-31225] - update certificates [DOM-31225] - update certificates to allow verify to be false Aug 2, 2022
@ddl-olsonJD ddl-olsonJD changed the title [DOM-31225] - update certificates to allow verify to be false [DOM-31225] - update certificates to bypass verify Aug 2, 2022
@ddl-olsonJD ddl-olsonJD marked this pull request as ready for review August 2, 2022 02:11
@ddl-olsonJD ddl-olsonJD requested a review from a team August 2, 2022 02:11
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ddl-alexpanin ddl-alexpanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CHANGELOG.md Outdated Show resolved Hide resolved
@ddl-olsonJD ddl-olsonJD merged commit 7565448 into master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants