[DOM-39831] - added forward slash check for file upload #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also update the changelog |
ddl-olsonJD
requested changes
Aug 18, 2022
domino/domino.py
Outdated
| @@ -667,6 +667,8 @@ def files_list(self, commitId, path="/"): | |||
| return self._get(url) | |||
|
|
|||
| def files_upload(self, path, file): | |||
| if path[0] != "/": | |||
There was a problem hiding this comment.
nit picking here, but can we use startswith instead?
ddl-olsonJD
changed the title
ddl-olsonJD
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-39831
What issue does this pull request solve?
When a file that is being uploaded does not have a forward slash at the beginning it throws an error
What is the solution?
Added a checker to make sure the file still gets uploaded either way.
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)