DOCS-1533 - Updated README in Markdown #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add new methods for tagging projects.
….com/dominodatalab/python-domino into DOCS-1533-convert-readme-to-asciidoc
… into DOCS-1533-dont-convert-readme-to-asciidoc
ddl-olsonJD
approved these changes
Aug 22, 2022
ddl-olsonJD
added a commit
that referenced
this pull request
Aug 22, 2022
* RM-1594 - updated python version to 1.1.0 * RM-1594 - updated version file * DOCS-1533 - Updated README in Markdown (#149) * Convert from markdown to Asciidoc * Oops, add the new file. * Copyediting and formatting. * Give code blocks source types * Minor formatting and editing. * Update the API docs links, add subheadings to the Methods section, and add new methods for tagging projects. * Feedback from @ddl-olsonJD * Minor formatting * Formatting. * DOCS-1533 - Updated * and _ usage, and some rewording (#148) * Add links to code examples. * Update the version to 1.1.0. * Convert the updated README back to Markdown from Asciidoc. * DOCS-1533 - updated changelog Co-authored-by: ddl-olsonJD <105082373+ddl-olsonJD@users.noreply.github.com> Co-authored-by: Olson J Dimanche <olson.dimanche@dominodatalab.com> Co-authored-by: Laurel Gaddie <89212537+ddl-lgaddie@users.noreply.github.com>
ddl-olsonJD
added a commit
that referenced
this pull request
Aug 23, 2022
* RM-1594 - updated python version to 1.1.0 * RM-1594 - updated version file * DOCS-1533 - Updated README in Markdown (#149) * Convert from markdown to Asciidoc * Oops, add the new file. * Copyediting and formatting. * Give code blocks source types * Minor formatting and editing. * Update the API docs links, add subheadings to the Methods section, and add new methods for tagging projects. * Feedback from @ddl-olsonJD * Minor formatting * Formatting. * DOCS-1533 - Updated * and _ usage, and some rewording (#148) * Add links to code examples. * Update the version to 1.1.0. * Convert the updated README back to Markdown from Asciidoc. * DOCS-1533 - updated changelog Co-authored-by: ddl-olsonJD <105082373+ddl-olsonJD@users.noreply.github.com> Co-authored-by: Olson J Dimanche <olson.dimanche@dominodatalab.com> * RM-1594 - updated dependency * RM-1594 - updated dependency * RM-1594 - updated dependencies and versioning Co-authored-by: Laurel Gaddie <89212537+ddl-lgaddie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOCS-1533
What issue does this pull request solve?
This PR replaces #146
What is the solution?
Instead of Asciidoc, the canonical README will be in Markdown, then converted to Asciidoc at build time.
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)