DOM-40791 Integrate with Domino API Proxy #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-sean-floyd
force-pushed
the
sean.floyd/DOM-40791/api-proxy-integration
branch
from
b6cffe5
to
a1ebc09
Compare
dmitriyvolk
approved these changes
Oct 5, 2022
ddl-olsonJD
reviewed
Oct 6, 2022
| def __init__(self, api_proxy): | ||
| self.api_proxy = api_proxy | ||
|
|
||
| def __call__(self, r): |
There was a problem hiding this comment.
can we update the header here as well, stating the auth method?
| return r | ||
|
|
||
| def __initialize__(self, session): | ||
| session.proxies.update({ |
domino/authentication.py
Outdated
| """ | ||
|
|
||
| if auth_token is not None: | ||
| if api_proxy is not None: |
There was a problem hiding this comment.
if api_proxy: is also another option.
ddl-olsonJD
approved these changes
Oct 6, 2022
ddl-olsonJD
reviewed
Oct 6, 2022
ddl-sean-floyd
force-pushed
the
sean.floyd/DOM-40791/api-proxy-integration
branch
from
9082a2a
to
2228b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-40791
What issue does this pull request solve?
Integrate the new Domino API Proxy into all API calls.
What is the solution?
Domino API Proxy is given precedence over all other auth types, both explicit, or implicit through environment variables.
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)