DOM-41022 add compute_cluster_properties param to DominoSparkOperator #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will be merged after 5.3.1 release |
|
I am having trouble running the unit tests. The code changes are pretty simple. It would be awesome if someone can run the unit tests and let me know. Thanks! |
….DominoSparkOperator-compute_cluster_properties # Conflicts: # CHANGELOG.md # tests/test_spark_operator.py
ddl-olsonJD
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
https://dominodatalab.atlassian.net/browse/DOM-41022
What issue does this pull request solve?
DominoSparkOperator does not support compute_cluster_properties param
What is the solution?
add support for compute_cluster_properties in DominoSparkOperator
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)