Add compute cluster properties to job launching #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkouznetsov
approved these changes
Mar 23, 2021
niole
force-pushed
the
niole.DOM-27821.add-support-for-cluster-properties-domino-python
branch
from
b6b1970
to
1c1cf86
Compare
chittshota
suggested changes
Apr 27, 2021
There was a problem hiding this comment.
@niole Changes look fine other than the master storage option. Can you remove it completely here. masterStorage is becoming obsolete. We can remove it here and later on from the backend as well. For now this API doesn't need to send any value for masterStorage or None/Non-validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compute cluster support to the start job endpoint. This looks like it is the only endpoint that can launch cluster related executions, so I only added it there.
There doesn't seem to be a standardized way for doing input validation, yet there is input validation on the start job endpoint, so I added basic input validation for the compute cluster definition. I did not do validation on whether the HWTs or env ids exist or not, because domino will reject with informative messaging if that is the case.
https://dominodatalab.atlassian.net/browse/DOM-27821