Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js 18 #1

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Support Node.js 18 #1

merged 4 commits into from
Jan 11, 2023

Conversation

dominykas
Copy link
Owner

@dominykas dominykas commented Jan 11, 2023

  • This starts off at rethinkdb-ts@2.4.22 (because 2.4.23 is the first broken version)
  • As ReadableStream.closed was introduced in Node.js 18, we need to rename the private Cursor.closed to avoid the naming collision.

@dominykas dominykas marked this pull request as ready for review January 11, 2023 11:42
@dominykas dominykas merged commit 626144a into main Jan 11, 2023
@dominykas dominykas deleted the fix-cursor-node18 branch January 11, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant