Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workspace errors #148

Merged
merged 4 commits into from
Mar 25, 2023
Merged

Fix workspace errors #148

merged 4 commits into from
Mar 25, 2023

Conversation

domjtalbot
Copy link
Owner

@domjtalbot domjtalbot commented Mar 23, 2023

Example projects are failing with the following error:

⨯ Unable to compile TypeScript:
error TS5024: Compiler option 'module' requires a value of type string.
error TS5024: Compiler option 'target' requires a value of type string.

What's Changed?

  1. Fix the workspace compilation errors
  2. Use SWC for nx-mesh build

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

⚠️ No Changeset found

Latest commit: e62200d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 24, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e62200d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 21 targets

Sent with 💌 from NxCloud.

@socket-security
Copy link

socket-security bot commented Mar 24, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Capability Access +/- Transitive Count Publisher
@swc/helpers@0.4.14 0.4.11...0.4.14 None +0/-0 kdy1
jest-environment-jsdom@28.1.1 29.3.0...28.1.1 None +12/-7 simenb
nx@9999.0.1 15.8.9...9999.0.1 None +55/-42 nrwl
babel-jest@28.1.1 28.1.3...28.1.1 environment +0/-0 simenb

🚮 Removed packages: @nrwl/cypress@15.8.5, @nrwl/js@15.8.5, @nrwl/linter@15.8.5, @nrwl/node@15.8.5, @nrwl/workspace@15.8.5, @swc-node/register@1.6.2, @swc/core@1.2.173, prettier@2.7.1

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit e62200d and detected 0 issues on this pull request.

View more on Code Climate.

@domjtalbot domjtalbot temporarily deployed to examples-sdk-nextjs-preview March 24, 2023 21:28 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to examples-sdk-nextjs-preview March 24, 2023 21:28 Inactive
@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
nx-mesh 4.0.0-alpha-20230324212812 npm ↗︎ unpkg ↗︎

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull-request.yml:codeql. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e62200d
✅ Preview: https://nx-mesh-rffhmroea-domjtalbot.vercel.app
🔍 Inspect: https://vercel.com/domjtalbot/nx-mesh/3dSc6FCdh71TnPx7r1dzHjcJ4AN8

View Workflow Logs

@github-actions github-actions bot added the vercel An issue or pull request related to Vercel label Mar 24, 2023
@domjtalbot domjtalbot changed the title build: fix workspace errors Fix workspace errors Mar 24, 2023
@domjtalbot domjtalbot self-assigned this Mar 24, 2023
@domjtalbot domjtalbot added the bug Indicates an unexpected problem or unintended behavior label Mar 24, 2023
@domjtalbot domjtalbot marked this pull request as ready for review March 24, 2023 21:40
@domjtalbot domjtalbot merged commit f22cd23 into main Mar 25, 2023
@domjtalbot domjtalbot deleted the fix/workspace branch March 25, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior vercel An issue or pull request related to Vercel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant