Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid validation on amount on all commands #9

Open
domlimm opened this issue Apr 16, 2022 · 1 comment
Open

Invalid validation on amount on all commands #9

domlimm opened this issue Apr 16, 2022 · 1 comment

Comments

@domlimm
Copy link
Owner

domlimm commented Apr 16, 2022

Steps to reproduce:

As per the feedback message, the formatting is correct.

add d/test a/9.123 t/2022-04-16

Expected:

Understand that in UG under add command, amount has a constraint of up to 2 decimal places. But would be good to specify a 'global' note.

Perhaps, a stronger validation on the message. Or even rounding the amount!

Includes commands such as budget ..., add ..., edit ....

Actual:

image.png

@domlimm domlimm changed the title Invalid validation Invalid validation on amount Apr 16, 2022
@domlimm domlimm changed the title Invalid validation on amount Invalid validation on amount on all commands Apr 16, 2022
@nus-se-script
Copy link

nus-se-script commented Apr 19, 2022

Team's Response

Rejected as it is feature flaw and not a functionality flaw.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: In my opinion, should still be accepted though tagged with the wrong type (apologies on that) as it is an actual bug that might have not been considered or missed out during the development phase.

Also, as mentioned by prof here, should not be rejected because of the wrong bug type.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants