-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve #316 - Add option to replace in
used in always_for_in
#380
Conversation
in
used in always_for_in
for_in_replacement::String = "in" | ||
end | ||
|
||
function valid_for_in_op(s::String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function valid_for_in_op(s::String) | |
valid_for_in_op(s::String) = s ∈ ("in", "=", "∈") |
And... maybe we can run this function in constructor of Options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes a lot of sense
Hi all, I'd really love to have this merged&released, is there anything I could potentially help with to get this through? |
Probably just has to be rebased. And also do this #380 (comment) |
OK, I'll push it to my fork ASAP. The rebase will be slightly challenging it seems. |
Add an option
for_in_replacement
, that works alongsidealways_for_in
whereby you can specify an alternative toin
.Can be used when
always_for_in
istrue
to replacein
with ∈ (\in), or=
instead: