Initial stage of JuliaSyntax #848
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domluna
commented
Jun 20, 2024
Comment on lines
+134
to
+137
| s.on && write(io, repeat(" ", max(nodes[i+1].indent, 0))) | ||
| s.line_offset = nodes[i+1].indent | ||
| elseif !skip_indent(nodes[i+1]) | ||
| write(io, ws) | ||
| s.on && write(io, ws) |
There was a problem hiding this comment.
this was a bug but I'm not sure it ever was an issue.
domluna
commented
Jun 20, 2024
src/print.jl
Outdated
Comment on lines
24
to
26
| if l1 <= nlines && output[end] == '\n' | ||
| output = output[1:prevind(output, end)] | ||
| end |
There was a problem hiding this comment.
NotCode nodes will add newlines so we need to remove these for now
domluna
commented
Jun 20, 2024
Comment on lines
+2
to
+15
| # using PrecompileTools | ||
| # @setup_workload begin | ||
| # dir = joinpath(@__DIR__,"..", "..") | ||
| # str = raw""" | ||
| # @noinline require_complete(m::Matching) = | ||
| # m.inv_match === nothing && throw(ArgumentError("Backwards matching not defined. `complete` the matching first.")) | ||
| # """ | ||
| # @compile_workload begin | ||
| # format(dir) | ||
| # for style = [DefaultStyle(), BlueStyle(), SciMLStyle(), YASStyle(), MinimalStyle()] | ||
| # format_text(str, style) | ||
| # end | ||
| # end | ||
| # end |
There was a problem hiding this comment.
disabled until this works
domluna
commented
Jun 20, 2024
Comment on lines
153
to
154
| # -1 signifies everything afterwards "#! format: off" | ||
| # will not formatted. |
There was a problem hiding this comment.
this comment is no longer applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stage for integrating JuliaSyntax. In this part I want to generate the Document using JuliaSyntax instead of the Tokenize package.
Current improvements:
I might actually just remove CSTParser completely since that might be easier but we'll see