Format only files selected by pre-commit #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you pass no files would be default to "." ? |
|
Pre-commit will skip a hook if there are no eligible files |
|
ok this looks good to me |
|
Can we have a new release so this and #840 are available, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook will be more useful if it would work on a list of files given to it by pre-commit. For instance
pre-commit runwill check only files in the staging area,pre-commit run --all-fileswill run on all the files. Additionally the hook should respect theexcludedirective of pre-commit.This PR adds support to working on the lists of files provided by pre-commit