Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the Georef Cam higher #23

Closed
turban opened this issue May 30, 2016 · 18 comments
Closed

Place the Georef Cam higher #23

turban opened this issue May 30, 2016 · 18 comments

Comments

@turban
Copy link

turban commented May 30, 2016

Sometimes I get black holes when I render the image:

screen shot 2016-05-30 at 21 25 32

This happens when there is a single peak that is higher than surrounding terrain. Is it possible to have the camera higher by default, so it's above all parts of the DEM?

@domlysz
Copy link
Owner

domlysz commented Jun 6, 2016

Thanks, fixed it in latest update. Please give it a try to confirm it's correct now

@domlysz domlysz closed this as completed Jun 9, 2016
@turban
Copy link
Author

turban commented Jun 18, 2016

The black hole is slightly smaller, but it is still present with the latest version:

blenderbug

@domlysz
Copy link
Owner

domlysz commented Jun 19, 2016

That strange the camera is placed 10 meters above the highest point of the mesh...

Maybee the subdivision level for the render is higher than the one for the 3view and there is no enough points around the pic to correctly estimate the maximum elevation of the rendering mesh.

I'will try to find a cleanest way to set the camera offset (I want avoid just setting an arbitrary value).

@domlysz domlysz reopened this Jun 19, 2016
@kikislater
Copy link

I think it just a blender basic tip. Under Camera > Lens, Set clipping start = 0

@turban
Copy link
Author

turban commented Jun 19, 2016

The clipping start is already 0 (or 0.001 to be exactly - if I try to change it to 0, Blender will change it back to 0.001):

screen shot 2016-06-19 at 12 56 42

@turban
Copy link
Author

turban commented Jun 19, 2016

The clipping end value is 951.700 in Blender, but in my GeoTIFF it is 961.400 (retrieved with gdalinfo).

@kikislater
Copy link

Could you give us the blend or part of the blend ?

@turban
Copy link
Author

turban commented Jun 19, 2016

This zip contains the GeoTIFF, the blend-file and the rendered image with the small black hole (left/middle):
https://dl.dropboxusercontent.com/u/2306934/MasterMaps/tile_13_09.zip

The black hole is "Himmeltindan" (964 m) in Lofoten archipelago: http://www.68north.com/outdoors/hiking-himmeltindan/

@kikislater
Copy link

Camera is very close to terrain in this part.
Modifiers : subdivision surface is set to 11, if you apply modifier or set to 9 black artefact disappear.

Place camera a little bit higher do the trick

@turban
Copy link
Author

turban commented Jun 19, 2016

@domlysz
Copy link
Owner

domlysz commented Jun 19, 2016

So the problem come well from subdivision. Actually the script compute the mesh bounding box and place the camera 10 meters higher, but if the view subdivision is lower than render subdivision then in some case the computing bounding box will not reflect the final bounding box because view subdivision don't provides enough points to get a displacement in "full resolution"

In your blend file, higher point of the mesh is under the camera
selection_020
selection_021

But if I set view subdivision to 11 then the mesh is above the camera

selection_022

@turban
Copy link
Author

turban commented Jun 19, 2016

What about adding a camera height of 100 m rather than 10?

@domlysz
Copy link
Owner

domlysz commented Jun 19, 2016

yes but it's not a clean and general way to solve the problem, the difference between view bounding box and render bounding box can be of any value, most of the time it will be few meters or decade of meters but potentially it can be lot of more.

However, I'm afraid that it's not possible to estimate the resulting bounding box without increase the view subdivision value (witch can involve lot of ram). So, I think I will add an option to edit the offset when the user create the camera. Also, expressed this value as percentage of z dimensions will be probably better than raw meters.

@turban
Copy link
Author

turban commented Jun 19, 2016

Sounds like a good plan :-)

@domlysz
Copy link
Owner

domlysz commented Aug 23, 2016

fixed 9bfbcb8

@domlysz domlysz closed this as completed Aug 23, 2016
@turban
Copy link
Author

turban commented Aug 31, 2016

Hi @domlysz, thanks for the fix - did you add an offset value and where can I edit it?

@domlysz
Copy link
Owner

domlysz commented Sep 2, 2016

You're right, I forgot to add a property for editing the value

Thanks

@domlysz domlysz reopened this Sep 2, 2016
@domlysz
Copy link
Owner

domlysz commented Jun 20, 2018

Finally fixed this one !
49130af

@domlysz domlysz closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants