Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidied up repo meta. #3

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Tidied up repo meta. #3

merged 1 commit into from
Oct 18, 2018

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Oct 8, 2018

Hi @domm

Please review the PR.
It proposed fix to the error "Skipping invalid git remote github" as below:

    [DZ] beginning to build Plack-App-ServiceStatus
    [DZ] guessing dist's main_module is lib/Plack/App/ServiceStatus.pm
    [VersionFromModule] dist version 0.903 (from lib/Plack/App/ServiceStatus.pm)
    [Repository] Skipping invalid git remote github
    [CheckChangeLog] [CheckChangeLog] OK with Changes
    [DZ] writing Plack-App-ServiceStatus in Plack-App-ServiceStatus-0.903
    [DZ] building archive with Archive::Tar::Wrapper
    [DZ] writing archive to Plack-App-ServiceStatus-0.903.tar.gz
    [DZ] built in Plack-App-ServiceStatus-0.903

According to the plugin "Dist::Zilla::Plugin::Repository":

    git_remote
    This is the name of the remote to use for the public repository (if you use Git). By default, 
    unsurprisingly, to origin.

Many Thanks.
Best Regards,
Mohammad S Anwar

@domm
Copy link
Owner

domm commented Oct 18, 2018

Hm, the real problem is that this dist has two remotes (github and a private one). On the machine I did the most work the origin is set to the private repo, and github is added as a second remote.

But as per default a clone from github will set github as origin it probably makes more sense to use github as the default (origin) repo.

Thus your MR makes sense and is now being applied (but I'll have to change my local gitconfig so future releases will point to github and not the internal repo)

@domm domm merged commit 37795bb into domm:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants