Moves sky sprites to its own package #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| # skysprites | |||
|
|
|||
| A minimal Sky project. | |||
There was a problem hiding this comment.
You probably want to update the readme.
|
lgtm |
vlidholt
added a commit
that referenced
this pull request
Aug 25, 2015
Moves sky sprites to its own package
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Optimize _looksLikeClassName() in AOT builds. The AOT compiler does not currently compile regexes to machine code, which makes them significantly slower. The regex in this function is perf critical and makes the dart_style benchmark 65% slower on AOT than on the JIT. This fixes some of that regression. Before: // JIT Best : 4.93ms ======================== Best : 4.83ms ======================== Best : 4.80ms ======================== // AOT Best : 8.33ms ========================================= Best : 8.43ms ========================================== Best : 8.37ms ========================================= After: // JIT Best : 4.93ms ======================== Best : 4.83ms ======================== Best : 4.80ms ======================== // AOT Best : 6.93ms ================================== Best : 6.87ms ================================== Best : 6.77ms ================================= * Don't crash if identifier is "_".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.