Replace External Font Awesome with Local SVG #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
force-pushed
the
local_svg_icon
branch
2 times, most recently
from
fabb773
to
97b8ef6
Compare
domoritz
approved these changes
Nov 26, 2021
Existing implementation reuse Font Awesome icons and spinner animation effect for simpler implementation. But this also lead to additional dependency which make 3rd party integration become harder. For example, in case of integrating Leaflet.Locate into [Drupal Leaflet](https://www.drupal.org/project/leaflet) module, the use of Font Awesome for icon introduce additional dependency to the needs of [Drupal Font Awesome](https://www.drupal.org/project/fontawesome). Sometime user may even hope to use a newer/older version of Font Awesome in their project, different than that well tested by ourselves. This PR decouple above issue by: - Locally vendor Font Awesome v5.15.4 `location-arrow-solid.svg` and `spinner-solid.svg` - Implement our own independent SCSS as similar as original design provided by Font Awesome - Simplify demo and README.md with above changes Fix domoritz#293 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
force-pushed
the
local_svg_icon
branch
from
97b8ef6
to
8a2fc29
Compare
hswong3i
added a commit
to drustack/brunob-leaflet.fullscreen
that referenced
this pull request
Nov 29, 2021
Existing implementation using `icon-fullscreen.png` and `icon-fullscreen-2x.png` for different screen (e.g. iOS with retina display). Moreover, we don't have any toggle effect for the icon status. This PR rework the icon with: * Locally vendor Font Awesome v5.15.4 `compress-solid.svg` and `expand-solid.svg` * Add default content for icon * Add toggle status for icon * Rework style with SCSS * Create minified version JS and CSS * Simplify demo and README.md with above changes Some style reuse from: domoritz/leaflet-locatecontrol#296 Online demo: https://drustack.github.io/brunob-leaflet.fullscreen/ Fix brunob#87 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation reuse Font Awesome icons and spinner animation effect for simpler implementation. But this also lead to additional dependency which make 3rd party integration become harder.
For example, in case of integrating Leaflet.Locate into Drupal Leaflet module, the use of Font Awesome for icon introduce additional dependency to the needs of Drupal Font Awesome.
Sometime user may even hope to use a newer/older version of Font Awesome in their project, different than that well tested by ourselves.
This PR decouple above issue by:
location-arrow-solid.svgandspinner-solid.svgOnline demo: https://drustack.github.io/domoritz-leaflet-locatecontrol/demo/
Fix #293
Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com