Put only city names into the app description

[mswart]

The application description should be improved by add only a list of supported cities (much smaller) and maybe later a full list or a link to a full list of canteens.

[jgraichen]

I think that would require to have a distinct city attribute on canteen resources available on OpenMensa API.

[mswart]

It could be done manually or via using the city value from the canteen address or do we not provide the address via the API?

[jgraichen]

Address is provided but you still need to parse that address and there is no standardized format (enforced). We should really add an additional city attribute.

[domoritz]

Since the API does not provide this information, I'm going to close this issue for now.

[jgraichen]

Canteen resources do have a city field.

[domoritz]

@l-jonas do you want to group canteens by city then?

[l-jonas]

@domoritz In the app description? Or are you talking about the canteen list? Which one (favorite selection or dropdown). The search in the favorite selection already uses the city field.

[domoritz]

I thought he meant the canteen list. It could be grouped by city or we could at least show the city in light gray below the name of the mensa. I don't really have strong opinions here.

[l-jonas]

The city field is currently not usable, some cities are a bit wrong:

• Würzburg, W
• Zürich, Zürich-Mülligen
• L instead of Lüneburg
• Halle, Halle (Saale)
• Garching, Garching bei München
• Frankfurt, Frankfurt am Main

[klemens]

@l-jonas

I corrected the ones you mentioned except Zürich, as I could not open the parser (server is rather slow currently). We could easily fix the rest. I also noticed that we currently do not display the city anywhere on the canteen site, but this should also be an easy fix.

When we have support for the cities in the app and on openmensa.org, we could then also remove the redundant city prefixes from the names (which have always annoyed me 😅).

Btw. I really like your update of the app!

[l-jonas]

@klemens There are still problems:

• the database contains two different writings for Würzburg
  • 259 is correct
  • the others have got a invisible special char between "Würz" and "burg"
  • this different cases are interpreted as different cities => not good
• now there is "Garching b.München" and "Garching bei München"
• and as you said, Zürich

I've built a two level canteen selection (city, then the canteen within the city; both lists suggest nearby items if a location is available). This needs an accurate city list without duplicates.

[klemens]

@l-jonas

Würzburg

There was a SOFT HYPHEN in there, which should normally be ignored by a unicode string comparison (e.g. in the firefox site search, it finds both the ones with and without hyphens when searching for Würzburg). But I have removed it anyway.

Garching

Fixed, there were actually two parsers für München. 🤔

Zürich

Still cannot open the parser (openmensa/openmensa#97), but fixed https://openmensa.org/c/646 manually. Not sure if there are more.

[l-jonas]

@klemens Thanks.