Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightSwitch/Contact is clickable in floorplan. #6081

Closed
szczukot opened this issue May 12, 2024 · 6 comments
Closed

LightSwitch/Contact is clickable in floorplan. #6081

szczukot opened this issue May 12, 2024 · 6 comments

Comments

@szczukot
Copy link
Contributor

On the floorplan, I can click (try cahnge state) for LightSwitch / Switch / Contact.

On tab with switches it is non-clickable (correct)

@waltervl
Copy link
Collaborator

Please use the forum for these kind of questions or experiences.
In the Tab Lights/Switches you can also click on the device Icon to switch the state (On/Off).
Check if you have any browser cache left of an old Domoticz version.

@szczukot
Copy link
Contributor Author

Hmmm, I don't understand.
I'm talking about switch type = contact
This is bug. Contact type switch should not be clickable.

@waltervl waltervl reopened this May 13, 2024
@waltervl waltervl changed the title LightSwitch/Contact is clickable LightSwitch/Contact is clickable in floorplan. May 13, 2024
@waltervl
Copy link
Collaborator

You can try to fix function Contact(item) in https://github.com/domoticz/domoticz/blob/development/www/js/domoticzdevices.js
It seems different from function DoorContact(item)

@szczukot
Copy link
Contributor Author

I see this is a bigger problem.
When I use the default icon, I can't click it.
When I change the icon, for example to heating, I can click it.

@waltervl
Copy link
Collaborator

Doorcontact has a special entry for custom icon so perhaps use that part of the code also for normal contact.

@gizmocuz
Copy link
Contributor

This is correct, you should not be able to click on a 'contact' type, in the floorplan it displays the log
I changed this in a recent commit, so this won't display the log, and you can hover your mouse over the item to display the popup and select 'log' from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants