Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NdefRecord::encode id bug #30

Closed
MatthewWilcock opened this issue Dec 4, 2015 · 3 comments
Closed

NdefRecord::encode id bug #30

MatthewWilcock opened this issue Dec 4, 2015 · 3 comments

Comments

@MatthewWilcock
Copy link

The payload is copied before the id, which results in a corrupted record. The payload should be copied after the id.
The bug is between lines 173 and 180 of NdefRecord.cpp
@jlkalberer
Copy link
Contributor

Created a pull request for this here - #31

@don
Copy link
Owner

don commented Dec 8, 2015

screen shot 2015-12-08 at 4 23 28 pm

don added a commit that referenced this issue Dec 8, 2015
@don
Test encoding record with id. See #30.
1ab3a61 
Add setId and getId to other tests.
@don
Copy link
Owner

don commented Dec 8, 2015

Fixed in pull request #31

@don don closed this as completed Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@don @jlkalberer @MatthewWilcock