Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NSBluetoothAlwaysUsageDescription for IOS13+ #704

Merged
merged 10 commits into from
Oct 17, 2019
Merged

add NSBluetoothAlwaysUsageDescription for IOS13+ #704

merged 10 commits into from
Oct 17, 2019

Conversation

favnec5
Copy link
Contributor

@favnec5 favnec5 commented Oct 12, 2019

nsbluetoothperipheralusagedescription is deprecated in Ios 13+
We should add NSBluetoothAlwaysUsageDescription in the plugin.xml with old $BLUETOOTH_USAGE_DESCRIPTION variable.

nsbluetoothperipheralusagedescription is deprecated in ios 13+
Add NSBluetoothAlwaysUsageDescription in the plugin.xml with old $BLUETOOTH_USAGE_DESCRIPTION variable.
Add NSLocationAlwaysUsageDescription (bluetooth need location too) into plist
@don don merged commit f8bbda2 into don:master Oct 17, 2019
@don
Copy link
Owner

don commented Oct 17, 2019

@favnec5 which part of this plugin needed NSLocationAlwaysAndWhenInUseUsageDescription?

don added a commit that referenced this pull request Oct 17, 2019
@favnec5
Copy link
Contributor Author

favnec5 commented Oct 18, 2019

Hi Don,
Sorry, i use PhoneGap in the clood to compile my bluetooth app, it's the mess in my Github fork !
This is the plugin.xml file.

  1. The Old NSBluetoothPeripheralUsageDescription is deprecated.
    Replaced by NSBluetoothAlwaysUsageDescription.
  2. But my App was refused by Apple because NSLocationUsageDescription / NSLocationWhenInUseUsageDescription / NSLocationAlwaysAndWhenInUseUsageDescription are also required.
    I publish App on the app Store yesterday with NSLocationUsageDescription, it beautifully passed :-)
    I add $LOCATION_USAGE_DESCRIPTION to do that.
    But I think NSLocationAlwaysAndWhenInUseUsageDescription could do in all cases.
    Best reguards,
    Thomas

@favnec5
Copy link
Contributor Author

favnec5 commented Oct 18, 2019

Note : I will test NSLocationAlwaysAndWhenInUseUsageDescription
instead of NSLocationUsageDescription on my next app submited to Apple
Best Reguard

@don
Copy link
Owner

don commented Oct 18, 2019

I kept the old NSBluetoothPeripheralUsageDescription in the code for iOS 12 devices. I removed the NSLocation* property because I don't think anything in this plugin is requiring it. If I'm wrong, let me know which APIs are the cause and I'll get it added back in.

@favnec5
Copy link
Contributor Author

favnec5 commented Oct 21, 2019

I think this is exactly what happened here.
The Core Location provides services that determine a device’s geographic location, altitude, and orientation, or its position relative to a nearby iBeacon device. The framework gathers data using all available components on the device, including the Wi-Fi, GPS, Bluetooth, magnetometer, barometer, and cellular hardware.
Now, location and bluetooth are nested.
Best reguards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants