Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add androidx.annotation reference for RequiresPermission attribute #978

Merged
merged 4 commits into from
Aug 13, 2023

Conversation

peitschie
Copy link
Collaborator

Fixes #977

Avoids a build issue:

node_modules\@Ionic\utils-subprocess\dist\index.js:72
        promise.p.stdout?.pipe(stdoutBuf);
                         ^

SyntaxError: Unexpected token '.'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (J:\temp\temp\node_modules\@capacitor\cli\dist\ipc.js:6:28)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
Once using the right node version still results in a permissions challenge:

ERROR:/home/runner/work/cordova-plugin-ble-central/cordova-plugin-ble-central/temp/android/app/build/intermediates/packaged_manifests/debug/AndroidManifest.xml:26: AAPT: error: attribute android:usesPermissionFlags not found.
@peitschie
Copy link
Collaborator Author

peitschie commented Aug 13, 2023

Once using the right node version still results in a permissions challenge:

ERROR:/home/runner/work/cordova-plugin-ble-central/cordova-plugin-ble-central/temp/android/app/build/intermediates/packaged_manifests/debug/AndroidManifest.xml:26:
  AAPT: error: attribute android:usesPermissionFlags not found.

The recommended fix for this would be to use the slim variant for Capacitor.

@peitschie peitschie merged commit aaa158e into master Aug 13, 2023
7 checks passed
@peitschie peitschie deleted the androidx-deps branch August 13, 2023 23:39
@peitschie peitschie added this to the 1.7.1 milestone Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build L2CAPContext.java and Peripheral.java
1 participant