Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the field #7

Closed
paulgovan opened this issue Mar 9, 2020 · 6 comments
Closed

State of the field #7

paulgovan opened this issue Mar 9, 2020 · 6 comments

Comments

@paulgovan
Copy link

This issue is for github.com/openjournals/joss-reviews/issues/2111.

"Do the authors describe how this software compares to other commonly-used packages?"

It's pretty clear that the software is useful, but it's not really clear how this software compares to and is better in some way than other software that's currently available. In addition, the background on existing software seems incomplete, as there are numerous packages for building Bayesian graphical models.

@donaldRwilliams
Copy link
Owner

We are happy to include this. To our knowledge, for GGMs in particular (and not Bayesian networks), there are only two R packages (BDgraph and beam). We are not aware of others, but can take another look.

@donaldRwilliams
Copy link
Owner

We added a note to the README. To our knowledge, there is no R package that includes all the algorithms and methods.

@jayrobwilliams
Copy link

The updated README and paper note that there is no R package that implements all of these methods. Are there other R packages that implement different subsets of these methods? If so, they would be important to mention here. Is the new c++ implementation faster than these packages? This would also be good to mention.

@donaldRwilliams
Copy link
Owner

OK. I will add this

@jayrobwilliams
Copy link

I am satisfied with the way these issues have been addressed.

@donaldRwilliams
Copy link
Owner

To address these comments, we followed the suggestions of the reviewers to include a section comparing to other software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants