Hackathon 2019 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eslint-rules to packages installed by default.
…eslint-rules to packages installed by default.
…ort a more complex case than loading one single-level object.
# Conflicts: # src/lib/mysql/sqlDDL.ts # src/lib/mysql/sqlDML.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Don,
MySQL integration seems to be functional at a base level. We also left the existing SQL Server code alone and seems to remain functional based on our tests.
We took your suggestion to dynamically import libraries (i.e.,
require ddl from '${sqlType}DDL') but couldn't find a good way to do userequireorimportfrom an interpolated string (https://stackoverflow.com/questions/50379361/string-literal-expected-when-importing-in-typescript) that the compiler liked. So we went with kind of an adapter pattern approach.