Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder for ConfTable for Andy #121

Merged
merged 1 commit into from May 7, 2020
Merged

Add builder for ConfTable for Andy #121

merged 1 commit into from May 7, 2020

Conversation

gusennan
Copy link
Contributor

@gusennan gusennan commented May 7, 2020

KAWA doesn't like non-static inner classes. This is a workaround.

@gusennan gusennan merged commit 3c07fba into master May 7, 2020
@cuchaz
Copy link
Contributor

cuchaz commented May 7, 2020

Lol, looks like there was already a factory method. See:

OSPREY3/src/edu/duke/cs/osprey/confspace/ConfDB.java

Line 776 in cd5db8d

public ConfTable table(String name) {

@gusennan
Copy link
Contributor Author

gusennan commented May 7, 2020

🤯

gusennan added a commit that referenced this pull request May 7, 2020
@gusennan
Revert "Merge pull request #121 from donaldlab/confTableFactory"
ed0049d 
This reverts commit 3c07fba, reversing
changes made to 0fd9b21.
@gusennan gusennan deleted the confTableFactory branch May 18, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gusennan @cuchaz