Fix passing null to string parameter deprecation #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing "strpos(): Passing null to parameter donatj#1 ($haystack) of type string is deprecated"
|
Do you have a particular UA string that triggers the issue? |
Yes, our test suite contains a |
|
Thanks! I just wanted to potentially add a regression test. PHP 8.1 is really snippy about strings. |
|
I've just added a test. :) Can you please approve the workflow so that CI can be started? |
donatj
added a commit
that referenced
this pull request
Aug 8, 2022
|
This was manually merged as part of a35900b It has been tagged and released in https://github.com/donatj/PhpUserAgent/releases/tag/v1.7.0 Thanks again! |
|
Thank you for your quick help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated