Add: concurrent session requests eliminated #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes donavanbecker#4 This eliminates concurrent requests to the `session` API endpoint by caching the first request and returning it's result to subsequent calls as long as the request is still in flight. This should be a small help in avoiding rate-limiting.
donavanbecker
approved these changes
May 7, 2024
|
Thanks!!! |
Merged
donavanbecker
added a commit
that referenced
this pull request
May 8, 2024
## [1.0.0](https://github.com/donavanbecker/august-yale/tag/v1.0.0) (2024-05-07) ### What's Changed - Add: concurrent session requests eliminated, Thanks [@joeybaker](https://github.com/joeybakerThanks), [#6](#6) - Fix: let fetch errors bubble up, Thanks [@joeybaker](https://github.com/joeybakerThanks), [#5](#5) - Housekeeping and updated dependencies. **Full Changelog**: v0.2.0...v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation && 💡 Proposed solution
Fixes #4
This eliminates concurrent requests to the
sessionAPI endpoint by caching the first request and returning it's result to subsequent calls as long as the request is still in flight. This should be a small help in avoiding rate-limiting.⚙️ Release Notes
Added a little more defense against rate limiting by eliminating some concurrent requests to the August/Yale API
➕ Additional Information
If applicable, provide additional context in this section.
Testing
¯_(ツ)_/¯ I just translated what I had manually modified this package running in homebridge. It seems to have worked there.