Fix trailing slash on component name #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert(fs.existsSync(path.join(tmpDir, 'src', 'past-year', 'past-year', 'past-year.less')), 'past-year.less exists'); | ||
| assert(fs.existsSync(path.join(tmpDir, 'src', 'past-year', 'past-year', 'past-year.stache')), 'past-year.stache exists'); | ||
| assert(fs.existsSync(path.join(tmpDir, 'src', 'past-year', 'past-year', 'past-year-test.js')), 'past-year-test.js exists'); | ||
| assert(fs.existsSync(path.join(tmpDir, 'src', 'past-year', 'past-year', 'past-year.html')), 'past-year.html exists'); |
There was a problem hiding this comment.
Should these point to src/basics/past-year/?
There was a problem hiding this comment.
chasenlehara
changed the title
| @@ -41,10 +41,10 @@ module.exports = BaseGenerator.extend({ | |||
| when: !this.options.name | |||
| }).then(function(first) { | |||
| var name = this.options.name = this.options.name || first.name; | |||
| name = this.options.name = name.replace(/\/$/, ""); | |||
There was a problem hiding this comment.
This could be combined with the above line:
var name = this.options.name = (this.options.name || first.name).replace(/\/$/, "");…or maybe the first line could be simplified:
var name = this.options.name || first.name;
name = this.options.name = name.replace(/\/$/, "");
cherifGsoul
force-pushed
the
fix_trailing_slashes_when_running_add_component
branch
from
e0f49f6
to
4379e67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #248