-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simplify): Correct usage of 'target_index_count' #1268
Conversation
donmccurdy
commented
Feb 16, 2024
- fixes Simplify breaks due to assertion failed #1263
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
6611225
to
b24343e
Compare
@donmccurdy do you know if this is related and fixes zeux/meshoptimizer#661 ? |
@marwie very likely this would fix the discrepancy in the ratio (50% vs 90%), yes. I think it is unrelated to the error metric, though. This is published to v4 under the |
Thank you. I've updated to latest 3 release today but perhaps it's worth updating to 4 already then. From the roadmap it seems like there are no breaking changes #1136 |
I haven't written the changelog for v4 yet, but so far the breaking changes are minimal. Some options renamed, or with different default values. If you're using TypeScript, it should catch things. The larger breaking change in v4 will be #1141, which requires some changes to extension implementations. See the changes to This fix could be patched to a v3.10.x release safely, if that's better. |
If you can patch 3 that would be great. Simplified meshes look much better with this Is 1141 already part of the current alpha.10 version? I tested with 4 alpha.10 just now - on first sight it seems to be OK but I'd need to test more in other projects to be confident. |
Published to published v3.10.1. ✅ #1141 is not on the alpha release yet — everything on the alpha release has already been merged to the |
Thanks a lot! Time to update then 😎 |