Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines.node entry for CLI #595

Merged
merged 1 commit into from
May 31, 2022
Merged

Add engines.node entry for CLI #595

merged 1 commit into from
May 31, 2022

Conversation

donmccurdy
Copy link
Owner

Marks @gltf-transform/cli as incompatible with node <14. The compatibility requirement began with gltf transform v2 but was not marked in package.json at the time, leading to issues like #594.

@donmccurdy donmccurdy added feature New enhancement or request package:cli labels May 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #595 (c77c3f0) into main (53dccab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         115      115           
  Lines        3856     3856           
  Branches      961      961           
=======================================
  Hits         3216     3216           
  Misses        306      306           
  Partials      334      334           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53dccab...c77c3f0. Read the comment docs.

@donmccurdy donmccurdy merged commit c0d9564 into main May 31, 2022
@donmccurdy donmccurdy deleted the cli-engine-node-14 branch May 31, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New enhancement or request package:cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants