Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions] KHR_draco_mesh_compression (decode only) #96

Merged
merged 13 commits into from
Sep 18, 2020

Conversation

donmccurdy
Copy link
Owner

@donmccurdy donmccurdy commented Sep 17, 2020

1/2 for #9.

Remaining:

  • Tests
  • Documentation
  • Improve I/O roundtrip story

@donmccurdy donmccurdy added feature New enhancement or request package:extensions labels Sep 17, 2020
@donmccurdy donmccurdy added this to the Backlog milestone Sep 17, 2020
packages/lib/package.json Outdated Show resolved Hide resolved
@donmccurdy
Copy link
Owner Author

donmccurdy commented Sep 17, 2020

Including the Draco library seems to mess with my stack traces in node.js. This error shouldn't be related to draco at all, Draco wasn't involved at the code that failed. 😕

/Users/donmccurdy/Projects/glTF-Transform/node_modules/draco3dgltf/draco_decoder_gltf_nodejs.js:9
var Module=typeof DracoDecoderModule!=="undefined"?DracoDecoderModule:{};var isRuntimeInitialized=false;var isModuleParsed=false;Module["onRuntimeInitialized"]=function(){isRuntimeInitialized=true;if(isModuleParsed){if(typeof Module["onModuleLoaded"]==="function"){Module["onModuleLoaded"](Module)}}};Module["onModuleParsed"]=function(){isModuleParsed=true;if(isRuntimeInitialized){if(typeof Module["onModuleLoaded"]==="function"){Module["onModuleLoaded"](Module)}}};function isVersionSupported(versionString){if(typeof versionString!=="string")return false;const version=versionString.split(".");if(version.length<2||version.length>3)return false;if(version[0]==1&&version[1]>=0&&version[1]<=3)return true;if(version[0]!=0||version[1]>10)return false;return true}Module["isVersionSupported"]=isVersionSupported;var moduleOverrides={};var key;for(key in Module){if(Module.hasOwnProperty(key)){moduleOverrides[key]=Module[key

Error: abort(g: GLB must have exactly 1 buffer.). Build with -s ASSERTIONS=1 for more info.
    at process.abort (/Users/donmccurdy/Projects/glTF-Transform/node_modules/draco3dgltf/draco_decoder_gltf_nodejs.js:35:7672)
    at process.emit (events.js:214:15)
    at processPromiseRejections (internal/process/promises.js:201:33)
    at processTicksAndRejections (internal/process/task_queues.js:86:32)

Fixed with a custom build of draco3dgltf.

@donmccurdy donmccurdy modified the milestones: Backlog, v0.7 Sep 18, 2020
@donmccurdy donmccurdy marked this pull request as ready for review September 18, 2020 19:41
@donmccurdy donmccurdy merged commit f5ad307 into master Sep 18, 2020
@donmccurdy donmccurdy deleted the feat-draco-decode branch September 18, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New enhancement or request package:extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant