Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards brightness keys #29

Open
bogddeny opened this issue Feb 8, 2023 · 14 comments
Open

Backwards brightness keys #29

bogddeny opened this issue Feb 8, 2023 · 14 comments
Labels
bug Something isn't working

Comments

@bogddeny
Copy link

bogddeny commented Feb 8, 2023

Whenever I make any change to the keymap, the default brightness keys change to be backwards: brightness down becomes brightness up and brightness up becomes brightness down (F1 key becomes brightness up, F2 key becomes brightness down). This is not really an issue since i can easily fix it with the yml file, but it would be nice if it was fixed by default. Maybe this is expected behaviour and I missed something, in that case sorry.

I fixed it by doing this:
keys:
brightnessdown:
key: brightnessup
brightnessup:
key: brightnessdown

Keyboard: Nuphy Air75 (Firmware 0122)
NuDelta Version: 0.6.5
Windows 11 Version: 22H2 (OS Build 22621.1105)

Edit: Also tested on Arch Linux (6.1.10 zen), same thing happens with appimage version 0.6.5.

@bogddeny bogddeny changed the title Brightness keys backwards Backwards brightness keys Feb 8, 2023
@donn donn added the bug Something isn't working label Feb 12, 2023
@donn
Copy link
Owner

donn commented Feb 18, 2023

I... can't replicate this? I just hooked my keyboard up to my iPad after writing a trivial remap and the brightness keys seem to be working fine in both Windows and Mac modes. Granted, I am on Firmware 0110. Is anyone else experiencing this on 0110?

@bogddeny
Copy link
Author

It might be the firmware difference... I also tested on my laptop running both windows 11 and arch linux and had the same results, so it's probably not an issue with the specific computer, I didn't update the report since I thought it wasn't relevant.

I also used wshowkeys on arch to verify what was happening:
Basically whenever the F1 key is pressed wshowkeys says that XF86MonBrightnessUp is pressed and XF86MonBrightnessDown for the F2 key. Also, for some of the other F-keys I did not give any keyboard input result, but I have to verify which ones those were and get back to you on that, since I'm not at home right now.

P.S. Is there any way to upgrade and/or downgrade the firmware on the keyboard? So that I can maybe test if the firmware is the problem?

@donn
Copy link
Owner

donn commented Feb 18, 2023

This is the firmware I use: https://nuphy.com/pages/firmwares-for-air75

Scroll to the very bottom.

@bogddeny
Copy link
Author

I just downgraded the firmware to 0110 and the exact same thing happens, F1 is brightness up and F2 is brightness down.
Using version 0.6.6

@donn
Copy link
Owner

donn commented Feb 18, 2023

That is super weird. Last thing I can maybe think of is hardware revisions. When did you buy your Air75?

@bogddeny
Copy link
Author

I also just tested it on android 13 and I am having the exact same issue.

keys:
pgup:
key: home
pgdn:
key: end
home:
key: pgup
end:
key: pgdn
assistant:
key: ins
mackeys: {}

This is my entire config.

I ordered the keyboard on 14th of december 2022

@donn
Copy link
Owner

donn commented Feb 18, 2023

I loaded your config, and yeah, on my keyboard F1 is still brightness down and F2 is still brightness up.

image

Since you're familiar with the terminal- can you run ./nudelta -D default.bin -H default.hex then send those files over? I'll have to compare them to mine. I can only assume at this point there's a revision difference I'm unaware of.

@bogddeny
Copy link
Author

bogddeny commented Feb 18, 2023

Had some trouble compiling because of missing dependencies, but here you go:
default.zip

Edit: I also just tried firmware version 0124 which is the latest available on the nuphy discord, same result.

Edit 2: After quite a bit of testing I noticed some glitches on firmware 0110 that do not happen on other people's keyboards that happen with this firmware, when using the FN+whatever (example: reset keyboard or turn off the side LEDs) some rows on the keyboard might be getting too much voltage, because they become way too bright for a split second, I don't know if this indicates different keyboard hardware revisions or not.

@donn
Copy link
Owner

donn commented Feb 24, 2023

@bogddeny Just to confirm- is this after you attempted to reconfigure it using Nudelta?

Curiously, the only thing I can find that's different between my keyboard's default keymap and this keymap is just this:
image

@bogddeny
Copy link
Author

I'm pretty sure it is, I do not know if it matters that I loaded the keymap in the GUI version and then used the CLI version to get those hex and bin files...

So if I tell it step by step:

  1. I downgraded the firmware to 0110
  2. I loaded the exact config I sent you 3 messages back, using the GUI version of NuDelta
  3. I compiled the CLI version of NuDelta
  4. I ran the command that you sent me

Maybe I'm dumb but should I try loading the keymap using the CLI version and then get the hex and bin files, would that make a difference?

Random idea that might be stupid:
Is it possible for me to use the NuPhy Console to load my config and then dump the default bin and hex files using NuDelta, and then use NuDelta to load the same config and dump the bin and hex files? Would they be comparable? Maybe you would see the differences there? I don't know if it's feasible, it's just an idea.

@donn
Copy link
Owner

donn commented Feb 26, 2023

Actually, what I'd like you to do is simply factory-reset the Air75 then run the command.

@bogddeny
Copy link
Author

Sorry for taking so long... here you go, the files after a factory reset.
default.zip

@finalpatch
Copy link

I have the same issue. The brightness key mapping works as expected after a factory reset, but will be reversed after loading a keymap with nudelta. It feels like a keycode/index has changed meaning between hardware revisions.

@donn
Copy link
Owner

donn commented Mar 16, 2024

Huh, I ran into this now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants