Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed prompt-toolkit version & updated README #22

Merged
merged 2 commits into from
May 14, 2016
Merged

Changed prompt-toolkit version & updated README #22

merged 2 commits into from
May 14, 2016

Conversation

jashgala
Copy link
Contributor

@jashgala jashgala commented May 11, 2016

Fix for issue #21.

This allows gitsome to be compatible with haxor-news. Incompatibility was caused because of conflict in the requirement of prompt-toolkit versions.

Was unable to update egg-info since it was in .gitignore

Also updated README.md to include relevant details for pip and Python version related issue (refer #4).

@jashgala jashgala changed the title Changed prompt-toolkit version to 0.52 Changed prompt-toolkit version & updated README May 11, 2016
@donnemartin
Copy link
Owner

Thanks for the pull request. Were you able to verify the fish style auto suggester works as expected?

@jashgala
Copy link
Contributor Author

Yes, it works fine on my system. The autosuggestions are shown and right clicking does select the autosuggestions.

@donnemartin
Copy link
Owner

Great, thanks. I'll try to do some testing too and get this merged in the next day or so.

@donnemartin donnemartin merged commit 88cdfb7 into donnemartin:master May 14, 2016
@donnemartin
Copy link
Owner

Merged, thank you!


For example, Ubuntu users can use:

$ sudo apt-get install python-pip3
Copy link
Owner

@donnemartin donnemartin May 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: For users still running into installation issues, this typo was fixed in:

https://github.com/donnemartin/gitsome/pull/30/files.

The correct command is:

 $ sudo apt-get install python3-pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants