Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays_Strings compress challenge tests inconsistent #236

Closed
alpertoygar opened this issue May 25, 2018 · 1 comment
Closed

Arrays_Strings compress challenge tests inconsistent #236

alpertoygar opened this issue May 25, 2018 · 1 comment

Comments

@alpertoygar
Copy link

In the chellenge compress there are tests:

assert_equal(func(None), None)
        assert_equal(func(''), '')
        assert_equal(func('AABBCC'), 'AABBCC')
        assert_equal(func('AAABCCDDDDE'), 'A3BC2D4E')
        assert_equal(func('BAAACCDDDD'), 'BA3C2D4')
        assert_equal(func('AAABAACCDDDD'), 'A3BA2C2D4')

The question states compress only if saves space but while a test is not changing the 2 consecutive letters as seen:

assert_equal(func('AABBCC'), 'AABBCC')

While the other exemples such as this one:

assert_equal(func('AAABCCDDDDE'), 'A3BC2D4E')

compresses it.

If this is not intended and if I'm not terribly wrong 😄 then some of the tests must be changed.

I would kindly offer my help to change them and open a PR if you would kindly point which ones need change (again if I'm correct)

@alpertoygar
Copy link
Author

Sorry there was a better one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant