Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate danman01's work into donnoman:master #3

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

donnoman
Copy link
Owner

@danman01 Thank you for the work.

I've added some questions and comments, this is really close to be being able to be pulled into my repo.

@@ -0,0 +1,149 @@
# @author Donovan Bray <donnoman@donovanbray.com>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These top comments obviously came from the nginx recipe, and should be removed from the postgresql recipe.

I suggest you update the author tag with your email. But you can omit it if you want. I just think it's good to know who was the brainchild behind each recipe.

@danman01
Copy link

Hey Donnoman, I've got a few things in here that need some more love and a few that wouldn't work for everyone, so I'll let you know once I've updated my branch and we can try to merge them into your master. Thanks!

@donnoman
Copy link
Owner Author

@danman01 any movement on this?

@danman01
Copy link

Hey Donnoman - I need to revisit this and haven't touched it for a while.
I'll let you know if I bring it up to speed.

Thanks!

On Wed, Feb 19, 2014 at 11:38 PM, Donovan Bray notifications@github.comwrote:

@danman01 https://github.com/danman01 any movement on this?

Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-35588693
.

about.me/dannykirschner
@danman01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants