fix: clean code

rollup.config.js

@@ -17,25 +17,6 @@ const isProduction = process.env.BUILD === 'production'
 const libDir = path.resolve(__dirname, 'lib')
 const srcDir = path.resolve(__dirname, 'src')
 
-export default () => [
-  getConfig({
-    optimize: true,
-    file: path.resolve(libDir, 'quasar-tiptap.min.js'),
-    format: 'umd',
-    esModule: true,
-  }),
-  getConfig({
-    optimize: true,
-    file: path.resolve(libDir, 'quasar-tiptap.common.js'),
-    format: 'cjs',
-  }),
-  getConfig({
-    file: path.resolve(libDir, 'quasar-tiptap.esm.js'),
-    format: 'es',
-    esModule: true,
-  }),
-]
-
 function getConfig ({
   file,
   format,
@@ -137,3 +118,22 @@ function getConfig ({
     ],
   }
 }
+
+export default () => [
+  getConfig({
+    optimize: true,
+    file: path.resolve(libDir, 'quasar-tiptap.min.js'),
+    format: 'umd',
+    esModule: true,
+  }),
+  getConfig({
+    optimize: true,
+    file: path.resolve(libDir, 'quasar-tiptap.common.js'),
+    format: 'cjs',
+  }),
+  getConfig({
+    file: path.resolve(libDir, 'quasar-tiptap.esm.js'),
+    format: 'es',
+    esModule: true,
+  }),
+]

src/extentions/Heading.js

@@ -2,6 +2,19 @@ import { Node } from 'tiptap'
 import { setBlockType, textblockTypeInputRule, toggleBlockType } from 'tiptap-commands'
 import { ParagraphNodeSpec, getParagraphNodeAttrs, toParagraphDOM } from 'src/extentions/Paragraph'
 
+function getUuid () {
+  const s = []
+  const hexDigits = '0123456789abcdef'
+  for (let i = 0; i < 36; i++) {
+    s[i] = hexDigits.substr(Math.floor(Math.random() * 0x10), 1)
+  }
+  s[14] = '4' // bits 12-15 of the time_hi_and_version field to 0010
+  s[19] = hexDigits.substr((s[19] & 0x3) | 0x8, 1) // bits 6-7 of the clock_seq_hi_and_reserved to 01
+  s[8] = s[13] = s[18] = s[23] = '' // -
+
+  return s.join('').substr(0, 6)
+}
+
 function getAttrs (dom) {
   const attrs = getParagraphNodeAttrs(dom)
   const id = dom.getAttribute('id')
@@ -78,16 +91,3 @@ export default class Heading extends Node {
     ))
   }
 }
-
-function getUuid () {
-  const s = []
-  const hexDigits = '0123456789abcdef'
-  for (let i = 0; i < 36; i++) {
-    s[i] = hexDigits.substr(Math.floor(Math.random() * 0x10), 1)
-  }
-  s[14] = '4' // bits 12-15 of the time_hi_and_version field to 0010
-  s[19] = hexDigits.substr((s[19] & 0x3) | 0x8, 1) // bits 6-7 of the clock_seq_hi_and_reserved to 01
-  s[8] = s[13] = s[18] = s[23] = '' // -
-
-  return s.join('').substr(0, 6)
-}

src/extentions/Paragraph.js

@@ -1,20 +1,5 @@
 import { Paragraph as TiptapParagraph } from 'tiptap'
 
-export const ParagraphNodeSpec = {
-  attrs: {
-    textAlign: { default: null },
-    indent: { default: null },
-    lineHeight: { default: null },
-  },
-  content: 'inline*',
-  group: 'block',
-  parseDOM: [{
-    tag: 'p',
-    getAttrs,
-  }],
-  toDOM,
-}
-
 function getAttrs (dom) {
   let {
     textAlign,
@@ -56,6 +41,21 @@ function toDOM (node) {
   return ['p', attrs, 0]
 }
 
+export const ParagraphNodeSpec = {
+  attrs: {
+    textAlign: { default: null },
+    indent: { default: null },
+    lineHeight: { default: null },
+  },
+  content: 'inline*',
+  group: 'block',
+  parseDOM: [{
+    tag: 'p',
+    getAttrs,
+  }],
+  toDOM,
+}
+
 export default class Paragraph extends TiptapParagraph {
   get schema () {
     return ParagraphNodeSpec

src/index.js

@@ -10,7 +10,7 @@ const QuasarTiptapPlugin = {
   spellcheck: true,
 
   install (Vue, opts = {}) {
-    this.spellcheck = opts.spellcheck == null
+    this.spellcheck = opts.spellcheck === null
       ? true
       : opts.spellcheck
     Vue.prototype.$o.lang.set(opts.language)

src/lang.js

@@ -10,7 +10,7 @@ export default {
       lang.set = this.set
       lang.getLocale = this.getLocale
 
-      if ($o !== undefined && $o.lang !== undefined) {
+      if ($o && $o.lang) {
         $o.lang = lang
       } else {
         Vue.util.defineReactive($o, 'lang', lang)
@@ -19,7 +19,7 @@ export default {
       this.isoName = lang.isoName
       this.nativeName = lang.nativeName
       this.props = lang
-      console.log('install lang, $o', language, lang, $o)
+      // console.log('install lang, $o', language, lang, $o)
     }
 
     this.set(language)

src/utils/alignment.js

@@ -40,7 +40,9 @@ export function setAlignment (tr, alignment) {
     return true
   })
 
-  if (!tasks.length) return tr
+  if (!tasks.length) {
+    return tr
+  }
 
   tasks.forEach(job => {
     const { node, pos, nodeType } = job

src/utils/format_clear.js

@@ -20,16 +20,22 @@ const FORMAT_MARK_NAMES = [
 
 export function clearMarks (tr, schema) {
   const { doc, selection } = tr
-  if (!selection || !doc) return tr
+  if (!selection || !doc) {
+    return tr
+  }
 
   const { from, to, empty } = selection
-  if (empty) return tr
+  if (empty) {
+    return tr
+  }
 
   const markTypesToRemove = new Set(
     FORMAT_MARK_NAMES.map(n => schema.marks[n]).filter(Boolean)
   )
 
-  if (!markTypesToRemove.size) return tr
+  if (!markTypesToRemove.size) {
+    return tr
+  }
 
   const tasks = []
   doc.nodesBetween(from, to, (node, pos) => {

src/utils/indent.js

@@ -9,7 +9,9 @@ import { clamp } from './shared'
 function updateIndentLevel (tr, delta) {
   const { doc, selection } = tr
 
-  if (!doc || !selection) return tr
+  if (!doc || !selection) {
+    return tr
+  }
 
   if (!(selection instanceof TextSelection || selection instanceof AllSelection)) {
     return tr
@@ -37,10 +39,14 @@ function updateIndentLevel (tr, delta) {
 }
 
 function setNodeIndentMarkup (tr, pos, delta) {
-  if (!tr.doc) return tr
+  if (!tr.doc) {
+    return tr
+  }
 
   const node = tr.doc.nodeAt(pos)
-  if (!node) return tr
+  if (!node) {
+    return tr
+  }
 
   const minIndent = 0
   const maxIndent = 7
@@ -57,7 +63,6 @@ function setNodeIndentMarkup (tr, pos, delta) {
     ...node.attrs,
     indent,
   }
-  console.log('indent', nodeAttrs, node.marks)
 
   return tr.setNodeMarkup(pos, node.type, nodeAttrs, node.marks)
 }
@@ -81,7 +86,9 @@ export function createIndentCommand (delta) {
 export function cleanIndent (tr) {
   const { doc, selection } = tr
 
-  if (!doc || !selection) return tr
+  if (!doc || !selection) {
+    return tr
+  }
 
   if (!(selection instanceof TextSelection || selection instanceof AllSelection)) {
     return tr

src/utils/line_height.js

@@ -40,7 +40,9 @@ export function setLineHeight (tr, lineHeight) {
     return true
   })
 
-  if (!tasks.length) return tr
+  if (!tasks.length) {
+    return tr
+  }
 
   tasks.forEach(job => {
     const { node, pos, nodeType } = job

src/utils/mark.js

@@ -15,19 +15,25 @@ function markApplies (doc, ranges, type) {
       can = node.inlineContent && node.type.allowsMarkType(type)
       return true
     })
-    if (can) return true
+    if (can) {
+      return true
+    }
   }
   return false
 }
 
 // https://github.com/ProseMirror/prosemirror-commands/blob/master/src/commands.js
 function applyMark (tr, markType, attrs) {
-  if (!tr.selection || !tr.doc || !markType) return tr
+  if (!tr.selection || !tr.doc || !markType) {
+    return tr
+  }
 
   // @ts-ignore
   const { empty, $cursor, ranges } = tr.selection
 
-  if ((empty && !$cursor) || !markApplies(tr.doc, ranges, markType)) return tr
+  if ((empty && !$cursor) || !markApplies(tr.doc, ranges, markType)) {
+    return tr
+  }
 
   if ($cursor) {
     tr = tr.removeStoredMark(markType)
@@ -57,7 +63,9 @@ function findActiveFontFamily (state) {
   const { schema, selection, tr } = state
   const markType = schema.marks.fontFamily
 
-  if (!markType) return ''
+  if (!markType) {
+    return ''
+  }
 
   const { empty } = selection
 
@@ -79,7 +87,9 @@ function findActiveFontFamily (state) {
   const attrs = getMarkAttrs(state, markType)
   const fontFamily = attrs.fontFamily
 
-  if (!fontFamily) return ''
+  if (!fontFamily) {
+    return ''
+  }
 
   return fontFamily
 }
@@ -88,7 +98,9 @@ function findActiveMarkAttribute (state, name) {
   const { schema, selection, tr } = state
   const markType = schema.marks[name]
 
-  if (!markType) return ''
+  if (!markType) {
+    return ''
+  }
 
   const { empty } = selection
 
@@ -110,7 +122,9 @@ function findActiveMarkAttribute (state, name) {
   const attrs = getMarkAttrs(state, markType)
   const value = attrs[name]
 
-  if (!value) return ''
+  if (!value) {
+    return ''
+  }
 
   return value
 }

src/utils/shared.js

@@ -7,7 +7,7 @@ export function noop () {}
 /**
  * Check whether a value is NaN
  */
-export function isNaN (any) {
+export function isNaN (val) {
   return Number.isNaN(val)
 }