Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEmbedMenu: settings button doesn't do anything #16

Closed
larvanitis opened this issue Jun 3, 2020 · 2 comments
Closed

OEmbedMenu: settings button doesn't do anything #16

larvanitis opened this issue Jun 3, 2020 · 2 comments
Labels

Comments

@larvanitis
Copy link
Contributor

It doesn't have any events bound to it. Maybe remove/hide it until it is fully implemented?

<o-common-item icon="settings" :label="$o.lang.label.settings" />

@mekery mekery closed this as completed in da28026 Jun 14, 2020
@mekery
Copy link
Contributor

mekery commented Jun 14, 2020

@larvanitis thanks

mekery pushed a commit that referenced this issue Jun 14, 2020
## [1.4.4](https://github.com/donotebase/quasar-tiptap/compare/@1.4.3...@1.4.4) (2020-06-14)

### Bug Fixes

* **editor:** remove unused console.log, fixed [#14](#14) ([f0c857b](f0c857b))
* **editor:** resolve untranslated label, fixed [#13](#13) ([f6fd5e7](f6fd5e7))
* **extension:** hide settins button, fixed [#16](#16) ([da28026](da28026))
* **image:** tooltips for lock aspect ratio, fixed [#15](#15) ([47e6903](47e6903))
* fixed json error ([0546f8f](0546f8f))
@mekery
Copy link
Contributor

mekery commented Jun 14, 2020

🎉 This issue has been resolved in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

yoshidev0428 added a commit to yoshidev0428/quasar_modis that referenced this issue Jun 25, 2023
## [1.4.4](https://github.com/donotebase/quasar-tiptap/compare/@1.4.3...@1.4.4) (2020-06-14)

### Bug Fixes

* **editor:** remove unused console.log, fixed [#14](donotebase/quasar-tiptap#14) ([f0c857b](donotebase/quasar-tiptap@f0c857b))
* **editor:** resolve untranslated label, fixed [#13](donotebase/quasar-tiptap#13) ([f6fd5e7](donotebase/quasar-tiptap@f6fd5e7))
* **extension:** hide settins button, fixed [#16](donotebase/quasar-tiptap#16) ([da28026](donotebase/quasar-tiptap@da28026))
* **image:** tooltips for lock aspect ratio, fixed [#15](donotebase/quasar-tiptap#15) ([47e6903](donotebase/quasar-tiptap@47e6903))
* fixed json error ([0546f8f](donotebase/quasar-tiptap@0546f8f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants