This repository has been archived by the owner on Feb 4, 2019. It is now read-only.
python no longer support headers with a colon #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for report! Instead of no longer outputting the headers, I suggest replacing the reference to |
|
That's better indeed. Done @dontcallmedom |
| @@ -127,7 +127,8 @@ def serveRequest(): | |||
| except WrongConfigurationException,e: | |||
| printError(output,doc, textoutputselected, "Could not run widlproc", str(e)) | |||
| for header_name in ('Last-Modified', 'Expires'): | |||
| if copyHeader(sys.stdout.write, srcheaders, header_name): | |||
| f = lambda header, value: sys.stdout.write("%s: %s" %(header, value)) | |||
There was a problem hiding this comment.
sorry to be picky, but if you're going to create a variable for this, you might as well create it outside of the for loop :)
|
@dontcallmedom what an idiot I am. Should be better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue25570
addheadershould take 2 parameters (header name, value). The last python upgrade breaks the current code as it adds a header named 'header:value' with an empty value.Unfortunately, the function passed to
copyHeadernow takes 2 arguments and are no longer compatible withsys.stdout.write