Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: moved encoding of response code section into transport pac… #16

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

donutloop
Copy link
Owner

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 20 of 38 (52.63%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 20.618%

Changes Missing Coverage Covered Lines Changed/Added Lines %
integration_tests/api_hello_world/helloworld.proto.go 2 4 50.0%
generator/proto/go/api.go 0 4 0.0%
framework/transport/transport.go 18 30 60.0%
Totals Coverage Status
Change from base Build 30: 0.3%
Covered Lines: 687
Relevant Lines: 3332

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 20 of 38 (52.63%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 20.618%

Changes Missing Coverage Covered Lines Changed/Added Lines %
integration_tests/api_hello_world/helloworld.proto.go 2 4 50.0%
generator/proto/go/api.go 0 4 0.0%
framework/transport/transport.go 18 30 60.0%
Totals Coverage Status
Change from base Build 30: 0.3%
Covered Lines: 687
Relevant Lines: 3332

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 4, 2018

Pull Request Test Coverage Report for Build 40

  • 33 of 79 (41.77%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 20.478%

Changes Missing Coverage Covered Lines Changed/Added Lines %
integration_tests/api_hello_world/helloworld.proto.go 5 6 83.33%
framework/transport/transport.go 28 50 56.0%
generator/proto/go/api.go 0 23 0.0%
Totals Coverage Status
Change from base Build 30: 0.1%
Covered Lines: 669
Relevant Lines: 3267

💛 - Coveralls

@donutloop donutloop force-pushed the api/refactoring branch 2 times, most recently from 45b052b to 7f4945b Compare March 4, 2018 11:01
hanling
Framework: moved encoding and decoding of response code section into transport package
API Generator: Introduced a generic content type serve handling

Signed-off-by: Marcel Edmund Franke <marcel.edmund.franke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants