feat(enh): typeguard cloned elements to remove warnings #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React may throw a warning related to issue #251 when undefined style props are provided to its elements. While this is generally not an issue in the real world, our customers may be annoyed by the warning message. In this commit, we have implemented a typeguard to address this issue when styling cloned elements.
Test Plan
Pass
Image
tostartElement
orendElement
in [Button] then you will not see the warning message.Related Issues
#251
Tests
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn test:all
and make sure nothing fails.