Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enh): typeguard cloned elements to remove warnings #252

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Feb 28, 2023

Description

React may throw a warning related to issue #251 when undefined style props are provided to its elements. While this is generally not an issue in the real world, our customers may be annoyed by the warning message. In this commit, we have implemented a typeguard to address this issue when styling cloned elements.

Test Plan

Pass Image to startElement or endElement in [Button] then you will not see the warning message.

Related Issues

#251

Tests

npx jest main/uis/Button

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added the 🎯 feature New feature label Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #252 (e948e83) into main (846dec3) will decrease coverage by 0.20%.
The diff coverage is 86.11%.

❗ Current head e948e83 differs from pull request most recent head 478214c. Consider uploading reports for the commit 478214c to get more accurate results

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   76.56%   76.36%   -0.20%     
==========================================
  Files          31       32       +1     
  Lines         862      876      +14     
  Branches      354      361       +7     
==========================================
+ Hits          660      669       +9     
- Misses        200      205       +5     
  Partials        2        2              

@hyochan hyochan merged commit 7785535 into main Feb 28, 2023
@hyochan hyochan deleted the enh/style-typeguard branch February 28, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant