Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: upgrade storybook to ver. 7 #534

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Feb 4, 2024

Description

Upgrade project to Storybook 7, https://storybook.js.org/releases/7.0.

During this migration, I've removed a large number of hard-coded stories. It would be better to reconstruct with simpler stories.

Tests

Not breaking previous tests.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added dependencies Pull requests that update a dependency file 🚽 migration Activities due to changes in framework labels Feb 4, 2024
@hyochan hyochan marked this pull request as ready for review February 4, 2024 15:17
@hyochan hyochan changed the title migration: upgrade storybook to ver 7 migration: upgrade storybook to ver. 7 Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #534 (edd174b) into main (1bbf896) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   75.47%   75.31%   -0.16%     
==========================================
  Files          36       36              
  Lines         946      948       +2     
  Branches      432      434       +2     
==========================================
  Hits          714      714              
- Misses        227      229       +2     
  Partials        5        5              

@hyochan hyochan merged commit fcf0697 into main Feb 4, 2024
1 of 3 checks passed
@hyochan hyochan deleted the migration/storybook-7 branch February 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 🚽 migration Activities due to changes in framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant