refactor: re-configure storybook hosting for web #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails build on web storybook
hyochan
force-pushed
the
migration/storybook-web
branch
from
f7a80ce
to
b4e9078
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 75.31% 75.23% -0.08%
==========================================
Files 36 36
Lines 948 945 -3
Branches 434 435 +1
==========================================
- Hits 714 711 -3
Misses 229 229
Partials 5 5 |
hyochan
force-pushed
the
migration/storybook-web
branch
from
b4e9078
to
b255d77
Compare
|
Visit the preview URL for this PR (updated for commit 81b116e): https://dooboo-ui--pr537-migration-storybook-tf6kh5t2.web.app (expires Wed, 14 Feb 2024 19:40:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a0e10c9c53f1ddcb575fbed95c0d86c6668ad0f0 |
Dark mode, and modal section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete the separately documented Storybook from the past, and change the structure to manage it together with the existing root project.
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn test:alland make sure nothing fails.