Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Implement] : FAB #67

Commits on Sep 7, 2021

  1. [implement]:FloationActionButotnWrapper(FAB)

    1. Implement basic FloationActionButotnWrapperProps
    	* active: boolean; //active ===true “expend ActionButtons”:” hide ActionButtons”
    	*DefaultMainActionButton: React.ReactElement; // show when active===false
    	*ActiveMainActionButton: React.ReactElement; // show when active===true
    	*ActionButtons: Array<React.ReactElement&gt;;// show when active===true
    	*top?: number; // fixedPosition of FAB
    	*bottom?: number;// fixedPosition of FAB
    	*left?: number; // fixedPosition of FAB
    	*right?: number; // fixedPosition of FAB
    2. Implement basic layout wrapper views for FloatingActionButtonWrapper(FAB) component.
    	* FixedPositionWrapperView sets overall position of FAB
    	* ExpendWrapperView makes expend animation along "active" value in props
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    b466d3c View commit details
    Browse the repository at this point in the history
  2. [implement] : FAB

    1. Implemented the basic functions of the FAB
    	* Can use IconButton that is a default button component of FAB by passing the icon types and callbacks.
    	* Can replace the default button component of FAB by passing renderButton function
    	* Can set absolute position of FAB
    	* Can replace buttons by active Props
    
    	Rendering conditions:
    		if(active===false)render DefaultFAB
    		if(active===true)render ActiveFAB and ActionButtons
    
    **Animation is not implemented**
    **Need more implementation**
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    7c8f556 View commit details
    Browse the repository at this point in the history
  3. [Improve]

    1. I simplified the props.
    	* DefaultFABItem, ActiveFABIItem were removed and renderIMainFAB function were provided for customization.
    	* Removed  props that receiving styles per attribute
    	* abstracted the FabItem data.
    	* provide onPressFABItem to receive onPress callback  (it will pass generic item data)
    
    2. Add FABStory
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    487809f View commit details
    Browse the repository at this point in the history
  4. [change]

    before
    	* isActive was props. but it makes it hard to provide an onPress callback.
    	* mainFAB Button was evaluated out side of return
    
    acter
    	* make isActive props to state
    	* pub mainFAB inside return
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    1c83173 View commit details
    Browse the repository at this point in the history
  5. [implement]

    Animation was implemented
    and Fix the story demo error
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ad7a3d1 View commit details
    Browse the repository at this point in the history
  6. [implement]

    1. MainFAB animation
    2. Implemented basic test that tests the callback
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    2c21481 View commit details
    Browse the repository at this point in the history
  7. [improve]

    1. change onpress callback naming
    before
    onPressFABItem
    after
    onPressListItem
    
    2.delete unnecessary import
    before
    React.ReactElement
    after
    deconstruct React and just import ReactElement
    
    3. delete the comment
    
    4. not to use index for the key of the list item
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    a4572ab View commit details
    Browse the repository at this point in the history
  8. [improvement]

    1. change Props naming
    2. changed behavior
    	 Previously, only the transparency of the button was adjusted depending on the state but now the actual position is adjusted.
    3. Change state management.
    	Previously, the active was managed as a "state", modified to manage it as a "props".
    4.  path name changed
    	FloatingActionButtonWrapper> FAB
    Juyeong-Byeon committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    f2a89e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. [Improvement]

        1. position translation has implemented
        2. naming has been changed
                  onPressListItem >   onPressFabItem
                  ItemList >  fabItems
        3. Bug that state was not synced with UI has fixed
    Juyeong-Byeon committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    4535cf5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. [code review]

    I reflected the contents of the code review.
    
    1. all fab -> FAB
    2. animation code improvement.
    	* delete duplicate
    3. some detail
    Juyeong-Byeon committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    afd59c4 View commit details
    Browse the repository at this point in the history