-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Implement] : FAB #67
Merged
yujonglee
merged 10 commits into
dooboolab-community:master
from
Juyeong-Byeon:main/FloatingActionButtonWrapper
Sep 19, 2021
Merged
[Implement] : FAB #67
yujonglee
merged 10 commits into
dooboolab-community:master
from
Juyeong-Byeon:main/FloatingActionButtonWrapper
Sep 19, 2021
Commits on Sep 7, 2021
-
[implement]:FloationActionButotnWrapper(FAB)
1. Implement basic FloationActionButotnWrapperProps * active: boolean; //active ===true “expend ActionButtons”:” hide ActionButtons” *DefaultMainActionButton: React.ReactElement; // show when active===false *ActiveMainActionButton: React.ReactElement; // show when active===true *ActionButtons: Array<React.ReactElement>;// show when active===true *top?: number; // fixedPosition of FAB *bottom?: number;// fixedPosition of FAB *left?: number; // fixedPosition of FAB *right?: number; // fixedPosition of FAB 2. Implement basic layout wrapper views for FloatingActionButtonWrapper(FAB) component. * FixedPositionWrapperView sets overall position of FAB * ExpendWrapperView makes expend animation along "active" value in props
Configuration menu - View commit details
-
Copy full SHA for b466d3c - Browse repository at this point
Copy the full SHA b466d3cView commit details -
1. Implemented the basic functions of the FAB * Can use IconButton that is a default button component of FAB by passing the icon types and callbacks. * Can replace the default button component of FAB by passing renderButton function * Can set absolute position of FAB * Can replace buttons by active Props Rendering conditions: if(active===false)render DefaultFAB if(active===true)render ActiveFAB and ActionButtons **Animation is not implemented** **Need more implementation**
Configuration menu - View commit details
-
Copy full SHA for 7c8f556 - Browse repository at this point
Copy the full SHA 7c8f556View commit details -
1. I simplified the props. * DefaultFABItem, ActiveFABIItem were removed and renderIMainFAB function were provided for customization. * Removed props that receiving styles per attribute * abstracted the FabItem data. * provide onPressFABItem to receive onPress callback (it will pass generic item data) 2. Add FABStory
Configuration menu - View commit details
-
Copy full SHA for 487809f - Browse repository at this point
Copy the full SHA 487809fView commit details -
before * isActive was props. but it makes it hard to provide an onPress callback. * mainFAB Button was evaluated out side of return acter * make isActive props to state * pub mainFAB inside return
Configuration menu - View commit details
-
Copy full SHA for 1c83173 - Browse repository at this point
Copy the full SHA 1c83173View commit details -
Animation was implemented and Fix the story demo error
Configuration menu - View commit details
-
Copy full SHA for ad7a3d1 - Browse repository at this point
Copy the full SHA ad7a3d1View commit details -
1. MainFAB animation 2. Implemented basic test that tests the callback
Configuration menu - View commit details
-
Copy full SHA for 2c21481 - Browse repository at this point
Copy the full SHA 2c21481View commit details -
1. change onpress callback naming before onPressFABItem after onPressListItem 2.delete unnecessary import before React.ReactElement after deconstruct React and just import ReactElement 3. delete the comment 4. not to use index for the key of the list item
Configuration menu - View commit details
-
Copy full SHA for a4572ab - Browse repository at this point
Copy the full SHA a4572abView commit details -
1. change Props naming 2. changed behavior Previously, only the transparency of the button was adjusted depending on the state but now the actual position is adjusted. 3. Change state management. Previously, the active was managed as a "state", modified to manage it as a "props". 4. path name changed FloatingActionButtonWrapper> FAB
Configuration menu - View commit details
-
Copy full SHA for f2a89e2 - Browse repository at this point
Copy the full SHA f2a89e2View commit details
Commits on Sep 16, 2021
-
1. position translation has implemented 2. naming has been changed onPressListItem > onPressFabItem ItemList > fabItems 3. Bug that state was not synced with UI has fixed
Configuration menu - View commit details
-
Copy full SHA for 4535cf5 - Browse repository at this point
Copy the full SHA 4535cf5View commit details
Commits on Sep 19, 2021
-
I reflected the contents of the code review. 1. all fab -> FAB 2. animation code improvement. * delete duplicate 3. some detail
Configuration menu - View commit details
-
Copy full SHA for afd59c4 - Browse repository at this point
Copy the full SHA afd59c4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.