Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week only page #1

Closed
juliocbcotta opened this issue Sep 12, 2018 · 15 comments
Closed

Week only page #1

juliocbcotta opened this issue Sep 12, 2018 · 15 comments
Labels
good first issue Good for newcomers

Comments

@juliocbcotta
Copy link

Hi, does this calendar supports weekly calendar? I mean, show only one week each time.
Thanks.

@hyochan
Copy link
Member

hyochan commented Sep 13, 2018

@BugsBunnyBR If you share a brief design for your request, I may consider it. I know what you are talking about but I may be misunderstanding how it may looks like.

@juliocbcotta
Copy link
Author

@dooboolab something like this one https://github.com/apptreesoftware/flutter_calendar .

@hyochan
Copy link
Member

hyochan commented Sep 13, 2018

@BugsBunnyBR Got it. But may take time though since I am busy doing other stuff.

@hyochan hyochan added the good first issue Good for newcomers label Sep 13, 2018
@lucasvienna
Copy link
Member

@dooboolab I would be interested in picking this one up, if you haven't gotten around to it yet.

@hyochan
Copy link
Member

hyochan commented Nov 9, 2018

Sorry I still haven't had time to do this job. @Avyiel I'd love to see your contribution on this one.

@lucasvienna
Copy link
Member

I implemented a similar solution to what @BugsBunnyBR suggested, but without the expandable calendar. It displays one week only and has all the same properties as the regular calendar. PR is incoming

hyochan added a commit that referenced this issue Nov 11, 2018
hyochan added a commit that referenced this issue Nov 11, 2018
hyochan added a commit that referenced this issue Nov 11, 2018
@hyochan
Copy link
Member

hyochan commented Nov 11, 2018

Hi. Sorry. I accidentally merged your incoming PR. Therefore, I've just reverted this one. Could you create another PR?

@lucasvienna
Copy link
Member

Hey @dooboolab, just opened a new PR with the same changes as before.

@hyochan
Copy link
Member

hyochan commented Nov 11, 2018

@Avyiel Thanks. Tell me again when it is ready to merge.

@lucasvienna
Copy link
Member

@dooboolab cleared up the pending merge conflicts, it's good to go now 😄

@hyochan
Copy link
Member

hyochan commented Nov 13, 2018

@Avyiel I've published to 1.1.10 with the support of weekFormat. However, I've not yet supported carousel because I felt I need one-working day to do this which I might not be available till Jan 2019. I might have time after that.

@lucasvienna
Copy link
Member

@dooboolab Understood. I'll try to implement carousel functionality over the week then. You can probably expect a new PR soon :)

@lucasvienna
Copy link
Member

hello @dooboolab, just submitted a PR with the carousel version of the week-only format. Managed to remove some duplicate code along the way too, since both views can now use the same underlying functions

@hyochan
Copy link
Member

hyochan commented Nov 17, 2018

Closed from 1.2.0.

@hyochan hyochan closed this as completed Nov 17, 2018
@linuxeasy
Copy link

The week-format should had been showing the current or selected date's week.

But it shows a previous week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants